[GitHub] [dolphinscheduler] qingwli commented on a diff in pull request #14743: [Feature][Authentication] support oauth2 login

["qingwli (via GitHub)" <gi...@apache.org>]

qingwli commented on code in PR #14743:
URL: https://github.com/apache/dolphinscheduler/pull/14743#discussion_r1298077609


##########
docs/docs/en/guide/security/authentication-type.md:
##########
@@ -1,6 +1,6 @@
 # Authentication Type
 
-* So far we support three authentication types, Apache DolphinScheduler password, LDAP and Casdoor SSO.
+* So far we support three authentication types, Apache DolphinScheduler password, LDAP,Casdoor SSO and OAuth2，the OAuth2 authorization login mode can be used with other authentication modes.

Review Comment:
   ```suggestion
   * So far we support three authentication types, Apache DolphinScheduler password, LDAP, Casdoor SSO and OAuth2，the OAuth2 authorization login mode can be used with other authentication modes.
   ```



##########
docs/docs/zh/guide/security/authentication-type.md:
##########
@@ -1,6 +1,6 @@
 # 认证方式
 
-* 目前我们支持三种认证方式，Apache DolphinScheduler自身账号密码登录，LDAP和通过Casdoor实现的SSO登录。
+* 目前我们支持三种认证方式，Apache DolphinScheduler自身账号密码登录，LDAP,通过Casdoor实现的SSO登录和通过Oauth2授权登录，并且oauth2授权登录方式可以和其他认证方式同时使用。

Review Comment:
   ```suggestion
   * 目前我们支持三种认证方式，Apache DolphinScheduler自身账号密码登录，LDAP, 通过Casdoor实现的SSO登录和通过Oauth2授权登录，并且Oauth2授权登录方式可以和其他认证方式同时使用。
   ```



##########
docs/docs/en/guide/security/authentication-type.md:
##########
@@ -1,6 +1,6 @@
 # Authentication Type
 
-* So far we support three authentication types, Apache DolphinScheduler password, LDAP and Casdoor SSO.
+* So far we support three authentication types, Apache DolphinScheduler password, LDAP,Casdoor SSO and OAuth2，the OAuth2 authorization login mode can be used with other authentication modes.

Review Comment:
   ```suggestion
   * So far we support three authentication types, Apache DolphinScheduler password, LDAP, Casdoor SSO and OAuth2，the OAuth2 authorization login mode can be used with other authentication modes.
   ```



##########
docs/docs/zh/guide/security/authentication-type.md:
##########
@@ -1,6 +1,6 @@
 # 认证方式
 
-* 目前我们支持三种认证方式，Apache DolphinScheduler自身账号密码登录，LDAP和通过Casdoor实现的SSO登录。
+* 目前我们支持三种认证方式，Apache DolphinScheduler自身账号密码登录，LDAP,通过Casdoor实现的SSO登录和通过Oauth2授权登录，并且oauth2授权登录方式可以和其他认证方式同时使用。

Review Comment:
   ```suggestion
   * 目前我们支持三种认证方式，Apache DolphinScheduler自身账号密码登录，LDAP, 通过Casdoor实现的SSO登录和通过Oauth2授权登录，并且Oauth2授权登录方式可以和其他认证方式同时使用。
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org