You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@river.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2009/05/18 04:43:45 UTC

[jira] Created: (RIVER-309) [patch] fix impossible conditional in CommitJob

[patch] fix impossible conditional in CommitJob
-----------------------------------------------

                 Key: RIVER-309
                 URL: https://issues.apache.org/jira/browse/RIVER-309
             Project: River
          Issue Type: Improvement
          Components: com_sun_jini_mahalo
         Environment: NA
            Reporter: Dave Brosius
            Priority: Trivial
         Attachments: impossiblecond.diff

'give up and quit' exit condition is

            if (attempt(who) > maxtries) {
                 return new Integer(COMMITTED);
             }

where maxtries is Integer.MAX_VALUE.

As this test will never be true, made it >= 

-- agreed highly unlikely ;)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (RIVER-309) [patch] fix impossible conditional in CommitJob

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/RIVER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated RIVER-309:
-------------------------------

    Attachment: impossiblecond.diff

> [patch] fix impossible conditional in CommitJob
> -----------------------------------------------
>
>                 Key: RIVER-309
>                 URL: https://issues.apache.org/jira/browse/RIVER-309
>             Project: River
>          Issue Type: Improvement
>          Components: com_sun_jini_mahalo
>         Environment: NA
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: impossiblecond.diff
>
>
> 'give up and quit' exit condition is
>             if (attempt(who) > maxtries) {
>                  return new Integer(COMMITTED);
>              }
> where maxtries is Integer.MAX_VALUE.
> As this test will never be true, made it >= 
> -- agreed highly unlikely ;)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (RIVER-309) [patch] fix impossible conditional in CommitJob

Posted by "Peter Firmstone (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/RIVER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Firmstone resolved RIVER-309.
-----------------------------------

    Resolution: Fixed

Patches supplied checked & merged.

> [patch] fix impossible conditional in CommitJob
> -----------------------------------------------
>
>                 Key: RIVER-309
>                 URL: https://issues.apache.org/jira/browse/RIVER-309
>             Project: River
>          Issue Type: Improvement
>          Components: com_sun_jini_mahalo
>         Environment: NA
>            Reporter: Dave Brosius
>            Assignee: Peter Firmstone
>            Priority: Trivial
>         Attachments: impossiblecond.diff
>
>
> 'give up and quit' exit condition is
>             if (attempt(who) > maxtries) {
>                  return new Integer(COMMITTED);
>              }
> where maxtries is Integer.MAX_VALUE.
> As this test will never be true, made it >= 
> -- agreed highly unlikely ;)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (RIVER-309) [patch] fix impossible conditional in CommitJob

Posted by "Peter Firmstone (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/RIVER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Firmstone reassigned RIVER-309:
-------------------------------------

    Assignee: Peter Firmstone

> [patch] fix impossible conditional in CommitJob
> -----------------------------------------------
>
>                 Key: RIVER-309
>                 URL: https://issues.apache.org/jira/browse/RIVER-309
>             Project: River
>          Issue Type: Improvement
>          Components: com_sun_jini_mahalo
>         Environment: NA
>            Reporter: Dave Brosius
>            Assignee: Peter Firmstone
>            Priority: Trivial
>         Attachments: impossiblecond.diff
>
>
> 'give up and quit' exit condition is
>             if (attempt(who) > maxtries) {
>                  return new Integer(COMMITTED);
>              }
> where maxtries is Integer.MAX_VALUE.
> As this test will never be true, made it >= 
> -- agreed highly unlikely ;)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.