You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by aparnard <gi...@git.apache.org> on 2016/06/29 23:13:26 UTC
[GitHub] incubator-geode pull request #178: GEODE-11: Pagination of Lucene query resu...
GitHub user aparnard opened a pull request:
https://github.com/apache/incubator-geode/pull/178
GEODE-11: Pagination of Lucene query results after entries are destroyed from the region
If a region entry is destroyed after a query is executed, the pages.next() call returns a null Value for the deleted entry. The code is changed to ignore deleted entries and fetch the next available entry so that the page count remains consistant. Added tests to verify scenarios of single, multiple and all region entry deletions.
Added a test to verify that all entries are fetched in one page when pagination is disabled.
Signed-off-by: Anilkumar Gingade <ag...@pivotal.io>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aparnard/incubator-geode feature/GEODE-11-PaginationTests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #178
----
commit d18be07b82d33bef5e060acc66b8d5ae1abedff1
Author: Aparna Dharmakkan <ad...@pivotal.io>
Date: 2016-06-29T23:06:38Z
GEODE-11: Pagination of Lucene Query Results after entries are destroyed from the region
If a region entry is destroyed after a query is executed, the pages.next() call returns
a null value for the deleted entry. The code is changed to ignore deleted entries and
fetch the next available entry so that the page count remains consistent. Added tests to
verify scenarios of single, multiple and all region entry deletions.
Added a test to verify that all entries are fetched in one page when pagination is
disabled.
Signed-off-by: Anilkumar Gingade <ag...@pivotal.io>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-geode issue #178: GEODE-11: Pagination of
Lucene query results aft...
Posted by Anilkumar Gingade <ag...@pivotal.io>.
Thats right....Its hard to predict if there could be any entries, by the
time hasNext() and next() is called...We need to capture this in the the
docs...
-Anil.
On Wed, Jun 29, 2016 at 5:27 PM, upthewaterspout <gi...@git.apache.org> wrote:
> Github user upthewaterspout commented on the issue:
>
> https://github.com/apache/incubator-geode/pull/178
>
> +1 looks good. One minor thing - I think could might result in
> hasNext() returning true followed by next() returning page with no elements
> if the last element gets deleted, is that right?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-geode issue #178: GEODE-11: Pagination of Lucene query results aft...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:
https://github.com/apache/incubator-geode/pull/178
+1 looks good. One minor thing - I think could might result in hasNext() returning true followed by next() returning page with no elements if the last element gets deleted, is that right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #178: GEODE-11: Pagination of Lucene query resu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #178: GEODE-11: Pagination of Lucene query results aft...
Posted by gesterzhou <gi...@git.apache.org>.
Github user gesterzhou commented on the issue:
https://github.com/apache/incubator-geode/pull/178
The fix looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---