You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/19 16:29:45 UTC

[GitHub] [kafka] mumrah commented on pull request #12182: MINOR: Use dynamic metadata.version check for KIP-704

mumrah commented on PR #12182:
URL: https://github.com/apache/kafka/pull/12182#issuecomment-1131934558

   FeaturesImage has `metadataVersion()` method which we can make accessible through a supplier for the Image/Delta classes. For broker components like ReplicaManager, we can add an argument to applyDelta that indicates a MetadataVersion change. I had some code like this in the [original PR](https://github.com/apache/kafka/pull/11677/commits/83bbf3b21bb0d9f313aa251cf011ec35748876e2#diff-78812e247ffeae6f8c49b1b22506434701b1e1bafe7f92ef8f8708059e292bf0R2110), but we removed it since we didn't have any use cases yet.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org