You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/26 03:53:19 UTC
[GitHub] [cordova-plugin-splashscreen] erisu opened a new pull request #276: breaking: bump node support >=10.0.0
erisu opened a new pull request #276:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/276
### Motivation, Context & Description
* Bump the Node engine to `>=10.0.0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] jcesarmobile commented on pull request #276: breaking: bump node support >=10.0.0
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #276:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/276#issuecomment-650029447
Can’t we just remove the node entry? Other plugins don’t have it (didn’t check all, but didn’t see in 3 random ones)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] jcesarmobile commented on pull request #276: breaking: drop node engine requirement
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #276:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/276#issuecomment-650077593
Yeah, I can check them all later, but so far I’ve checked 3 and they didn’t have it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu merged pull request #276: breaking: drop node engine requirement
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #276:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] jcesarmobile commented on pull request #276: breaking: drop node engine requirement
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #276:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/276#issuecomment-650106816
I have reviewed all the plugins (even archived and deprecated ones) and none had a node requirement, so we are good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on pull request #276: breaking: bump node support >=10.0.0
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #276:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/276#issuecomment-650062721
Yeah, we could probably remove the node engine from our plugins.
The only thing that has a node requirement is the linting tool, but it is only for development purposes.
Our plugins do not use any hook-scripts or node-specific code in production, so there is no node execution. Only the Cordova CLI tooling, which does the copying and merging of the `src` or `www` content, has the requirement.
I think it is safe to drop it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org