You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/19 14:57:58 UTC

[GitHub] [skywalking-infra-e2e] mrproliu opened a new pull request #36: Fix the GHA docker compose wait strategy failure

mrproliu opened a new pull request #36:
URL: https://github.com/apache/skywalking-infra-e2e/pull/36


   Fix the docker compose wait for IP port failure when using GitHub Action.
   I found it's a bug in [testcontainers-go](https://github.com/testcontainers/testcontainers-go).
   
   I have already [submit a PR to track this one](https://github.com/testcontainers/testcontainers-go/pull/349), before that one merge and release, I provide related code into our project and fix the bug, filename called `compose-provider.go`. After this PR have been merge and release, I could remove useless code and use `testcontainers-go` project to verify the docker service health again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #36: Fix the GHA docker compose wait strategy failure

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #36:
URL: https://github.com/apache/skywalking-infra-e2e/pull/36#issuecomment-902468005


   @kezhenxu94 Could you take a review on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-infra-e2e] mrproliu merged pull request #36: Fix the GHA docker compose wait strategy failure

Posted by GitBox <gi...@apache.org>.
mrproliu merged pull request #36:
URL: https://github.com/apache/skywalking-infra-e2e/pull/36


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #36: Fix the GHA docker compose wait strategy failure

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #36:
URL: https://github.com/apache/skywalking-infra-e2e/pull/36#issuecomment-901994485


   Please fix the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #36: Fix the GHA docker compose wait strategy failure

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #36:
URL: https://github.com/apache/skywalking-infra-e2e/pull/36#issuecomment-902471891


   With https://github.com/apache/skywalking-infra-e2e/pull/37 , this is not a blocker and we can wait for testcontainer-go upstream to process @mrproliu 's PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org