[GitHub] [spark] bersprockets commented on pull request #39855: [SPARK-42286][SQL] Fallback to previous codegen code path for complex expr with CAST

["bersprockets (via GitHub)" <gi...@apache.org>]

bersprockets commented on PR #39855:
URL: https://github.com/apache/spark/pull/39855#issuecomment-1413984963

   Just a couple of questions:
   
   >create or replace table es570639t1 as select x FROM values (1), (2), (3) as tab(x);
   >create or replace table es570639t2 (x Decimal(9, 0));
   
   For the eventual commit message: Should that be `create table`.... instead of `create or replace table`...? or is that new syntax?
   
   For my own understanding: it seems that `CheckOverflowInTableInsert` previously assumed a `Cast` as child (and after SPARK-41991, assumed either a `Cast` or one wrapped by an `ExpressionProxy` ), but rules like `PushFoldableIntoBranches` make that assumption too rigid, correct?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org