[GitHub] [spark] shahidki31 commented on a change in pull request #25369: [SPARK-28638][WebUI] Task summary metrics are wrong when there are running tasks

[GitBox <gi...@apache.org>]

shahidki31 commented on a change in pull request #25369: [SPARK-28638][WebUI] Task summary metrics are wrong when there are running tasks
URL: https://github.com/apache/spark/pull/25369#discussion_r311479709
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
 ##########
 @@ -156,7 +162,8 @@ private[spark] class AppStatusStore(
     // cheaper for disk stores (avoids deserialization).
     val count = {
       Utils.tryWithResource(
-        if (store.isInstanceOf[InMemoryStore]) {
+        if (isInMemoryStore) {
 
 Review comment:
   Thanks @gengliangwang . History server uses `InMemory` store by default. For Disk store case,  this isn't an optimal way for finding success task. I am yet to raise a PR for supporting for Disk store case.  
   
   I think you just need to add,
    `isInMemoryStore: Boolean =  listener.isDefined || store.isInstanceOf[InMemoryStore]`
   
   Will test your code with all the scenarios.
   Any case, this would be temporary as we need to support for Diskstore also.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org