[GitHub] [spark] cloud-fan commented on a diff in pull request #38578: [SPARK-41064][CONNECT][PYTHON] Implement `DataFrame.crosstab` and `DataFrame.stat.crosstab`

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #38578:
URL: https://github.com/apache/spark/pull/38578#discussion_r1017875279


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -273,6 +274,21 @@ message StatFunction {
   message Summary {
     repeated string statistics = 1;
   }
+

Review Comment:
   shall we make the proto message a bit more flattened? It looks to me that the only shared part between `Summary` and `CrossTabulate` is the input relation. Shall we simply have 2 messages?
   ```
   message StatsSummary {
     Relation input = 1;
     ...
   }
   message StatsCrossTabulate {
     Relation input = 1;
     ...
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org