[GitHub] [pulsar] tisonkun commented on a diff in pull request #20981: [feat][build] Use git-archive to generate source release

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #20981:
URL: https://github.com/apache/pulsar/pull/20981#discussion_r1291508387


##########
src/stage-release.sh:
##########
@@ -26,13 +26,17 @@ if [ $# -eq 0 ]; then
 fi
 
 DEST_PATH=$1
+DEST_PATH="$(cd "$DEST_PATH" && pwd)"
 
 pushd $(dirname "$0")
 PULSAR_PATH=$(git rev-parse --show-toplevel)
 VERSION=`./get-project-version.py`
 popd
 
-cp $PULSAR_PATH/target/apache-pulsar-$VERSION-src.tar.gz $DEST_PATH
+pushd "$(dirname "$0")/.."

Review Comment:
   RM will still use `$PULSAR_PATH/src/stage-release.sh .` so it's an internal impl change which doesn't cause any external visible change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org