You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "smjn (via GitHub)" <gi...@apache.org> on 2026/04/28 10:22:03 UTC
[PR] KAFKA-20410: Register topic DLQ configs in LogConfig. [2/N] [kafka]
smjn opened a new pull request, #22167:
URL: https://github.com/apache/kafka/pull/22167
* Register TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_CONFIG in LogConfig.
* Update tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20410: Register topic DLQ configs in LogConfig. [2/N] [kafka]
Posted by "smjn (via GitHub)" <gi...@apache.org>.
smjn commented on PR #22167:
URL: https://github.com/apache/kafka/pull/22167#issuecomment-4334391192
```
➜ ak-smjn git:(trunk) bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --feature share.version=2 [15:14:21]
share.version was upgraded to 2.
➜ ak-smjn git:(trunk) ✗ bin/kafka-topics.sh --bootstrap-server localhost:9092 --create --topic dlq.SG1 [15:21:56]
WARNING: Due to limitations in metric names, topics with a period ('.') or underscore ('_') could collide. To avoid issues it is best to use either, but not both.
Created topic dlq.SG1.
➜ ak-smjn git:(trunk) ✗ bin/kafka-configs.sh --bootstrap-server localhost:9092 --alter --add-config "errors.deadletterqueue.topic.name=dlq.SG1" --entity-type groups --entity-name sg1
Completed updating config for group sg1.
➜ ak-smjn git:(trunk) ✗ bin/kafka-configs.sh --bootstrap-server localhost:9092 --alter --add-config "errors.deadletterqueue.group.enable=true" --entity-type topics --entity-name dlq.SG1
Completed updating config for topic dlq.SG1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20410: Register topic DLQ configs in LogConfig. [2/N] [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #22167:
URL: https://github.com/apache/kafka/pull/22167#discussion_r3154709918
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -279,6 +280,7 @@ public Optional<String> serverConfigName(String configName) {
public final BrokerCompressionType compressionType;
public final Optional<Compression> compression;
public final boolean preallocate;
+ public final boolean dlqEnabled;
Review Comment:
In principle, this should be the entirely wordy `errorsDeadletterqueueGroupEnable` I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20410: Register topic DLQ configs in LogConfig. [2/N] [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #22167:
URL: https://github.com/apache/kafka/pull/22167#discussion_r3154720346
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -248,7 +248,8 @@ public Optional<String> serverConfigName(String configName) {
TopicConfig.LOCAL_LOG_RETENTION_BYTES_DOC)
.define(TopicConfig.REMOTE_LOG_COPY_DISABLE_CONFIG, BOOLEAN, false, MEDIUM, TopicConfig.REMOTE_LOG_COPY_DISABLE_DOC)
.define(TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_CONFIG, BOOLEAN, false, MEDIUM, TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_DOC)
- .defineInternal(INTERNAL_SEGMENT_BYTES_CONFIG, INT, null, null, MEDIUM, INTERNAL_SEGMENT_BYTES_DOC);
+ .defineInternal(INTERNAL_SEGMENT_BYTES_CONFIG, INT, null, null, MEDIUM, INTERNAL_SEGMENT_BYTES_DOC)
+ .define(TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_CONFIG, BOOLEAN, false, MEDIUM, TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_DOC);
Review Comment:
I'd probably re-order these too like @apoorvmittal10 suggests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20410: Register topic DLQ configs in LogConfig. [2/N] [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield merged PR #22167:
URL: https://github.com/apache/kafka/pull/22167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20410: Register topic DLQ configs in LogConfig. [2/N] [kafka]
Posted by "apoorvmittal10 (via GitHub)" <gi...@apache.org>.
apoorvmittal10 commented on code in PR #22167:
URL: https://github.com/apache/kafka/pull/22167#discussion_r3154085059
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -248,7 +248,8 @@ public Optional<String> serverConfigName(String configName) {
TopicConfig.LOCAL_LOG_RETENTION_BYTES_DOC)
.define(TopicConfig.REMOTE_LOG_COPY_DISABLE_CONFIG, BOOLEAN, false, MEDIUM, TopicConfig.REMOTE_LOG_COPY_DISABLE_DOC)
.define(TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_CONFIG, BOOLEAN, false, MEDIUM, TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_DOC)
- .defineInternal(INTERNAL_SEGMENT_BYTES_CONFIG, INT, null, null, MEDIUM, INTERNAL_SEGMENT_BYTES_DOC);
+ .defineInternal(INTERNAL_SEGMENT_BYTES_CONFIG, INT, null, null, MEDIUM, INTERNAL_SEGMENT_BYTES_DOC)
+ .define(TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_CONFIG, BOOLEAN, false, MEDIUM, TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_DOC);
Review Comment:
Minor nit: Not sure if `defineInternal` is deliberately kept as last entry in the list. If so, we might want to reorder and keep `defineInternal` as last entry in the list. I can see you have kept the order in LogConfigTest.
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -387,6 +390,10 @@ public int initFileSize() {
return 0;
}
+ public boolean dlqEnabled() {
Review Comment:
nit: dlqEnabled -< dlqEnable. As like for other configs mathcing the name, for boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20410: Register topic DLQ configs in LogConfig. [2/N] [kafka]
Posted by "apoorvmittal10 (via GitHub)" <gi...@apache.org>.
apoorvmittal10 commented on code in PR #22167:
URL: https://github.com/apache/kafka/pull/22167#discussion_r3154084475
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -387,6 +390,10 @@ public int initFileSize() {
return 0;
}
+ public boolean dlqEnabled() {
Review Comment:
nit: dlqEnabled -> dlqEnable. As like for other configs mathcing the name, for boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org