You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/12 15:33:53 UTC
[GitHub] [incubator-kyuubi] zhaomin1423 opened a new pull request, #2340: [WIP][KYUUBI #2021] Command OptionParser for launching Hive Backend Engine
zhaomin1423 opened a new pull request, #2340:
URL: https://github.com/apache/incubator-kyuubi/pull/2340
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #2340: [WIP][KYUUBI #2021] Command OptionParser for launching Hive Backend Engine
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #2340:
URL: https://github.com/apache/incubator-kyuubi/pull/2340#issuecomment-1096915492
> > these args are all in the strict form of --conf key=val
>
> currently, we pass them in procbuilder as java options in -Dkey=val form
Thanks, I see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhaomin1423 closed pull request #2340: [WIP][KYUUBI #2021] Command OptionParser for launching Hive Backend Engine
Posted by GitBox <gi...@apache.org>.
zhaomin1423 closed pull request #2340: [WIP][KYUUBI #2021] Command OptionParser for launching Hive Backend Engine
URL: https://github.com/apache/incubator-kyuubi/pull/2340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2340: [WIP][KYUUBI #2021] Command OptionParser for launching Hive Backend Engine
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #2340:
URL: https://github.com/apache/incubator-kyuubi/pull/2340#issuecomment-1096902839
> these args are all in the strict form of --conf key=val
currently, we pass them in procbuilder as java options in -Dkey=val form
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #2340: [WIP][KYUUBI #2021] Command OptionParser for launching Hive Backend Engine
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #2340:
URL: https://github.com/apache/incubator-kyuubi/pull/2340#issuecomment-1096889794
Could you help me review the underway work?If it is feasible, I will continue to do it. @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2340: [WIP][KYUUBI #2021] Command OptionParser for launching Hive Backend Engine
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #2340:
URL: https://github.com/apache/incubator-kyuubi/pull/2340#issuecomment-1096900579
you are in a wrong way. the option parser only need to parse args passed to XXXEngine.main. these args are all in the strict form of --conf key=val. the option parser parser them and set key-value to kyuubi conf and engine confs such as hive conf. the implantation then can be engine independent which could be placed in kyuubi common module or somewhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org