You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kobe6th (via GitHub)" <gi...@apache.org> on 2023/11/09 09:02:53 UTC
[PR] [branch-1.2][improvement](string) throw exception instead of log fata if string column exceed total size limit [doris]
kobe6th opened a new pull request, #26668:
URL: https://github.com/apache/doris/pull/26668
## Proposed changes
Issue Number: close #26667
ref: https://github.com/apache/doris/pull/17989
fix same issue on branch-1.2-lts
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-1.2][improvement](string) throw exception instead of log fata if string column exceed total size limit [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei closed pull request #26668: [branch-1.2][improvement](string) throw exception instead of log fata if string column exceed total size limit
URL: https://github.com/apache/doris/pull/26668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-1.2][improvement](string) throw exception instead of log fata if string column exceed total size limit [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26668:
URL: https://github.com/apache/doris/pull/26668#issuecomment-1805030720
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-1.2][improvement](string) throw exception instead of log fata if string column exceed total size limit [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26668:
URL: https://github.com/apache/doris/pull/26668#issuecomment-1805030748
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-1.2][improvement](string) throw exception instead of log fata if string column exceed total size limit [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #26668:
URL: https://github.com/apache/doris/pull/26668#issuecomment-1805171213
Not merge it.
Because 1.2 is not exception safe. If you throw exception here, there maybe memory leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org