You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/17 15:07:04 UTC
[jira] [Commented] (HTTPCLIENT-1726) The deprecated
SSLSocketFactory does not contain the SNI fix found in the
SSLConnectionSocketFactory class
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014168#comment-16014168 ]
ASF GitHub Bot commented on HTTPCLIENT-1726:
--------------------------------------------
Github user pono closed the pull request at:
https://github.com/apache/httpcomponents-client/pull/47
> The deprecated SSLSocketFactory does not contain the SNI fix found in the SSLConnectionSocketFactory class
> ----------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1726
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1726
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.4.1, 4.5.1
> Reporter: David
> Labels: SNI
> Fix For: 4.5.3
>
> Attachments: sni.patch
>
>
> Inside the deprecated [SSLSocketFactory.createSocket(final HttpContext context)|https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLSocketFactory.java#L521] method the fix that was applied for HTTPCLIENT-1119 to the SSLConnectionSocketFactory class is not present, see https://github.com/apache/httpclient/commit/92b7e8cd971868505d0f22ee5cfc12a68ee91b80 for the fix for HTTPCLIENT-1119. That is, the method needs to create and return a standard socket, which is then layered on top of such that SNI is enabled.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org