[GitHub] [openwhisk] style95 commented on a change in pull request #4646: Serialize `updated` value of entity document in response

[GitBox <gi...@apache.org>]

style95 commented on a change in pull request #4646: Serialize `updated` value of entity document in response
URL: https://github.com/apache/openwhisk/pull/4646#discussion_r346636890
 
 

 ##########
 File path: tests/src/test/scala/org/apache/openwhisk/core/controller/test/RulesApiTests.scala
 ##########
 @@ -61,6 +63,11 @@ class RulesApiTests extends ControllerTestCommon with WhiskRulesApi {
   val activeStatus = s"""{"status":"${Status.ACTIVE}"}""".parseJson.asJsObject
   val inactiveStatus = s"""{"status":"${Status.INACTIVE}"}""".parseJson.asJsObject
   val parametersLimit = Parameters.sizeLimit
+  val dummyInstant = Instant.now()
+
+  def checkResponse(response: WhiskRuleResponse, expected: WhiskRuleResponse) =
 
 Review comment:
   One small nit can be extracting this kind of methods into a trait.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services