You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2024/02/06 10:40:34 UTC
[PR] IGNITE-21111 Mechanism to wait for completion of in-flight operations of RW transactions started before index appearance [ignite-3]
tkalkirill opened a new pull request, #3160:
URL: https://github.com/apache/ignite-3/pull/3160
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21111 Mechanism to wait for completion of in-flight operations of RW transactions started before index appearance [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #3160:
URL: https://github.com/apache/ignite-3/pull/3160#discussion_r1480255738
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/replication/PartitionReplicaListenerTest.java:
##########
@@ -242,16 +243,20 @@ public class PartitionReplicaListenerTest extends IgniteAbstractTest {
private static final int ANOTHER_TABLE_ID = 2;
+ private static final long ANY_ENLISTMENT_CONSISTENCY_TOKEN = 1L;
+
private final Map<UUID, Set<RowId>> pendingRows = new ConcurrentHashMap<>();
/** The storage stores partition data. */
private final TestMvPartitionStorage testMvPartitionStorage = new TestMvPartitionStorage(PART_ID);
private final LockManager lockManager = new HeapLockManager();
- private final Function<PartitionCommand, CompletableFuture<?>> defaultMockRaftFutureClosure = cmd -> {
+ private final Function<Command, CompletableFuture<?>> defaultMockRaftFutureClosure = cmd -> {
Review Comment:
Author probably knows.
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java:
##########
@@ -43,9 +43,7 @@
import org.apache.ignite.internal.replicator.message.TimestampAware;
import org.apache.ignite.network.ClusterNode;
-/**
- * The service is intended to execute requests on replicas.
- */
+/** The service is intended to execute requests on replicas. */
Review Comment:
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21111 Mechanism to wait for completion of in-flight operations of RW transactions started before index appearance [ignite-3]
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov merged PR #3160:
URL: https://github.com/apache/ignite-3/pull/3160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21111 Mechanism to wait for completion of in-flight operations of RW transactions started before index appearance [ignite-3]
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov commented on code in PR #3160:
URL: https://github.com/apache/ignite-3/pull/3160#discussion_r1479862894
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/replication/PartitionReplicaListenerTest.java:
##########
@@ -242,16 +243,20 @@ public class PartitionReplicaListenerTest extends IgniteAbstractTest {
private static final int ANOTHER_TABLE_ID = 2;
+ private static final long ANY_ENLISTMENT_CONSISTENCY_TOKEN = 1L;
+
private final Map<UUID, Set<RowId>> pendingRows = new ConcurrentHashMap<>();
/** The storage stores partition data. */
private final TestMvPartitionStorage testMvPartitionStorage = new TestMvPartitionStorage(PART_ID);
private final LockManager lockManager = new HeapLockManager();
- private final Function<PartitionCommand, CompletableFuture<?>> defaultMockRaftFutureClosure = cmd -> {
+ private final Function<Command, CompletableFuture<?>> defaultMockRaftFutureClosure = cmd -> {
Review Comment:
Why is it necessary here?
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java:
##########
@@ -43,9 +43,7 @@
import org.apache.ignite.internal.replicator.message.TimestampAware;
import org.apache.ignite.network.ClusterNode;
-/**
- * The service is intended to execute requests on replicas.
- */
+/** The service is intended to execute requests on replicas. */
Review Comment:
I see what you did here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org