You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:18:55 UTC
[GitHub] [ambari] rickyma commented on a change in pull request #3198: AMBARI-25516. Missing @Override on 91 methods
rickyma commented on a change in pull request #3198:
URL: https://github.com/apache/ambari/pull/3198#discussion_r437320252
##########
File path: ambari-agent/src/main/java/org/apache/ambari/tools/zk/ZkConnection.java
##########
@@ -41,6 +41,7 @@ public static ZooKeeper open(String serverAddress, int sessionTimeoutMillis, int
{
final CountDownLatch connSignal = new CountDownLatch(1);
ZooKeeper zooKeeper = new ZooKeeper(serverAddress, sessionTimeoutMillis, new Watcher() {
Review comment:
Lambda expressions are not supported at language level '7'. ambari-agent is still using 1.7. Need I change that too? pom.xml under ambari-agent:
`
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.0</version>
<configuration>
<source>1.7</source>
<target>1.7</target>
</configuration>
</plugin>
`
##########
File path: ambari-agent/src/main/java/org/apache/ambari/tools/zk/ZkConnection.java
##########
@@ -41,6 +41,7 @@ public static ZooKeeper open(String serverAddress, int sessionTimeoutMillis, int
{
final CountDownLatch connSignal = new CountDownLatch(1);
ZooKeeper zooKeeper = new ZooKeeper(serverAddress, sessionTimeoutMillis, new Watcher() {
Review comment:
Lambda expressions are not supported at language level '7'. ambari-agent is still using 1.7. Need I change that too? pom.xml under ambari-agent:
##########
File path: ambari-server/src/main/java/org/apache/ambari/server/state/fsm/event/Event.java
##########
@@ -26,5 +26,6 @@
TYPE getType();
long getTimestamp();
+ @Override
Review comment:
OK, I'll remove it.
##########
File path: ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java
##########
@@ -290,6 +290,7 @@ private DirContextOperations setAmbariAdminAttr(DirContextOperations user, LdapS
LOG.debug("LDAP login - set admin attr filter: {}", setAmbariAdminAttrFilter);
AttributesMapper attributesMapper = new AttributesMapper() {
Review comment:
It's done.
##########
File path: ambari-server/src/main/java/org/apache/ambari/server/utils/ScheduledExecutorCompletionService.java
##########
@@ -35,6 +35,7 @@
super(task, null);
this.task = task;
}
+ @Override
protected void done() { queue.add(task); }
Review comment:
It's done.
##########
File path: ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
##########
@@ -1545,6 +1549,7 @@ public void addLdapAuthentication(UserEntity userEntity, String dn, boolean pers
UserAuthenticationType.LDAP,
StringUtils.lowerCase(dn), // DNs are case-insensitive and are stored internally as the bytes of lowercase characters
new Validator() {
Review comment:
It's done.
##########
File path: ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
##########
@@ -1504,6 +1507,7 @@ public void addPamAuthentication(UserEntity userEntity, String userName, boolean
UserAuthenticationType.PAM,
userName,
new Validator() {
Review comment:
It's done.
##########
File path: ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
##########
@@ -1463,6 +1465,7 @@ public void addLocalAuthentication(UserEntity userEntity, String password, boole
UserAuthenticationType.LOCAL,
encodedPassword,
new Validator() {
Review comment:
It's done.
##########
File path: ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
##########
@@ -1373,6 +1373,7 @@ public void addJWTAuthentication(UserEntity userEntity, String key, boolean pers
UserAuthenticationType.JWT,
key,
new Validator() {
Review comment:
It's done.
##########
File path: ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
##########
@@ -1415,6 +1416,7 @@ public void addKerberosAuthentication(UserEntity userEntity, String principalNam
UserAuthenticationType.KERBEROS,
principalName,
new Validator() {
+ @Override
Review comment:
It's done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org