You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "celeste-zeng (via GitHub)" <gi...@apache.org> on 2023/08/16 19:10:38 UTC

[GitHub] [beam] celeste-zeng opened a new pull request, #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python 3.11 containers

celeste-zeng opened a new pull request, #28036:
URL: https://github.com/apache/beam/pull/28036

   - Addressing https://github.com/apache/beam/issues/28035
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python containers

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #28036:
URL: https://github.com/apache/beam/pull/28036#issuecomment-1681380271

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn merged pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python containers

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn merged PR #28036:
URL: https://github.com/apache/beam/pull/28036


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] celeste-zeng commented on a diff in pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python containers

Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on code in PR #28036:
URL: https://github.com/apache/beam/pull/28036#discussion_r1296438161


##########
sdks/python/container/Dockerfile:
##########
@@ -80,6 +80,11 @@ RUN  \
     # Remove pip cache.
     rm -rf /root/.cache/pip
 
+# Required for using Beam Python SDK on ARM machines.
+RUN if [ "${TARGETARCH}" = "arm64" ] ; then \
+      apt-get install libgeos-dev ; \

Review Comment:
   - Tried to put it around line 42 earlier but I don't think the if condition can be inserted between different package names after calling apt-get install.
   - I can't run on this branch because it is just a fork of the apache/beam master not the original master branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python 3.11 containers

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #28036:
URL: https://github.com/apache/beam/pull/28036#discussion_r1296435073


##########
sdks/python/container/Dockerfile:
##########
@@ -80,6 +80,11 @@ RUN  \
     # Remove pip cache.
     rm -rf /root/.cache/pip
 
+# Required for using Beam Python SDK on ARM machines.
+RUN if [ "${TARGETARCH}" = "arm64" ] ; then \
+      apt-get install libgeos-dev ; \

Review Comment:
   > Also, did you run validatesconainerarm tests to verify this change ?
   
   you could post a link to GHA run on the PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python 3.11 containers

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #28036:
URL: https://github.com/apache/beam/pull/28036#discussion_r1296433672


##########
sdks/python/container/Dockerfile:
##########
@@ -80,6 +80,11 @@ RUN  \
     # Remove pip cache.
     rm -rf /root/.cache/pip
 
+# Required for using Beam Python SDK on ARM machines.
+RUN if [ "${TARGETARCH}" = "arm64" ] ; then \
+      apt-get install libgeos-dev ; \

Review Comment:
   i would suggest to move these statements to line 42 (keeping the statements inside one RUN command). note that apt temp files are cleared in line 44, and this command might require a prior call to `apt update`.
   
   Also, did you run validatesconainerarm tests to verify this change ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python 3.11 containers

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #28036:
URL: https://github.com/apache/beam/pull/28036#discussion_r1296435296


##########
sdks/python/container/Dockerfile:
##########
@@ -80,6 +80,11 @@ RUN  \
     # Remove pip cache.
     rm -rf /root/.cache/pip
 
+# Required for using Beam Python SDK on ARM machines.
+RUN if [ "${TARGETARCH}" = "arm64" ] ; then \
+      apt-get install libgeos-dev ; \

Review Comment:
   overall, pr intent looks good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python containers

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28036:
URL: https://github.com/apache/beam/pull/28036#issuecomment-1681300209

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @tvalentyn for label python.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python 3.11 containers

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28036:
URL: https://github.com/apache/beam/pull/28036#issuecomment-1681181491

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28036?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#28036](https://app.codecov.io/gh/apache/beam/pull/28036?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (99d9ab4) into [master](https://app.codecov.io/gh/apache/beam/commit/42ca3bf598e70e3baa550859de1d2ca6712bd8f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (42ca3bf) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #28036      +/-   ##
   ==========================================
   - Coverage   72.31%   72.30%   -0.01%     
   ==========================================
     Files         678      678              
     Lines       99744    99744              
   ==========================================
   - Hits        72127    72123       -4     
   - Misses      26057    26061       +4     
     Partials     1560     1560              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/beam/pull/28036/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [python](https://app.codecov.io/gh/apache/beam/pull/28036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.86% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/28036/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python 3.11 containers

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #28036:
URL: https://github.com/apache/beam/pull/28036#discussion_r1296433672


##########
sdks/python/container/Dockerfile:
##########
@@ -80,6 +80,11 @@ RUN  \
     # Remove pip cache.
     rm -rf /root/.cache/pip
 
+# Required for using Beam Python SDK on ARM machines.
+RUN if [ "${TARGETARCH}" = "arm64" ] ; then \
+      apt-get install libgeos-dev ; \

Review Comment:
   i would suggest to move it to line 42, note that apt temp files are cleared, and this command might require a prior call to `apt update`.
   
   Also, did you run validatesconainerarm tests to verify this change ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] celeste-zeng commented on pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python containers

Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on PR #28036:
URL: https://github.com/apache/beam/pull/28036#issuecomment-1681312917

   Run Python ValidatesContainer Dataflow ARM 3.11


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python containers

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #28036:
URL: https://github.com/apache/beam/pull/28036#discussion_r1296460156


##########
sdks/python/container/Dockerfile:
##########
@@ -80,6 +80,11 @@ RUN  \
     # Remove pip cache.
     rm -rf /root/.cache/pip
 
+# Required for using Beam Python SDK on ARM machines.
+RUN if [ "${TARGETARCH}" = "arm64" ] ; then \
+      apt-get install libgeos-dev ; \

Review Comment:
   I see. I think we can install unconditionally to avoid extra complexity. I suspect it current version might fail without apt update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] celeste-zeng commented on pull request #28036: Add libgeos-dev for ARM components of multi-arch Beam SDK Python containers

Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on PR #28036:
URL: https://github.com/apache/beam/pull/28036#issuecomment-1681298151

   Run Python ValidatesContainer Dataflow ARM 3.11


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org