You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Simon Brandhof (JIRA)" <ji...@codehaus.org> on 2010/02/18 23:19:55 UTC
[jira] Created: (MCHECKSTYLE-132) Upgrade to Checkstyle 5.1
Upgrade to Checkstyle 5.1
-------------------------
Key: MCHECKSTYLE-132
URL: http://jira.codehaus.org/browse/MCHECKSTYLE-132
Project: Maven 2.x Checkstyle Plugin
Issue Type: Improvement
Reporter: Simon Brandhof
[Release notes|http://checkstyle.sourceforge.net/releasenotes.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-132) Upgrade to Checkstyle 5.3
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated MCHECKSTYLE-132:
-------------------------------------
Summary: Upgrade to Checkstyle 5.3 (was: Upgrade to Checkstyle 5.1)
> Upgrade to Checkstyle 5.3
> -------------------------
>
> Key: MCHECKSTYLE-132
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-132
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Reporter: Simon Brandhof
> Attachments: checkstyle-5.3.patch
>
>
> [Release notes|http://checkstyle.sourceforge.net/releasenotes.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHECKSTYLE-132) Upgrade to Checkstyle 5.3
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed MCHECKSTYLE-132.
------------------------------------
Resolution: Fixed
Fix Version/s: 2.7
Assignee: Olivier Lamy
fixed [rev 1035854|http://svn.apache.org/viewvc?rev=1035854&view=rev]
> Upgrade to Checkstyle 5.3
> -------------------------
>
> Key: MCHECKSTYLE-132
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-132
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Reporter: Simon Brandhof
> Assignee: Olivier Lamy
> Fix For: 2.7
>
> Attachments: checkstyle-5.3.patch
>
>
> [Release notes|http://checkstyle.sourceforge.net/releasenotes.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MCHECKSTYLE-132) Upgrade to
Checkstyle 5.1
Posted by "Paul Nyheim (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=242206#action_242206 ]
Paul Nyheim edited comment on MCHECKSTYLE-132 at 11/5/10 6:41 AM:
------------------------------------------------------------------
patch against v2.6 in svn
-All tests run green.- _oops_
Forgot to run mvn clean test, so there are currently 7 failures. I'll have a quick look and see if I can fix them quickly...
was (Author: pnyheim):
patch against v2.6 in svn
All tests run green.
> Upgrade to Checkstyle 5.1
> -------------------------
>
> Key: MCHECKSTYLE-132
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-132
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Reporter: Simon Brandhof
> Attachments: checkstyle-5.3.patch
>
>
> [Release notes|http://checkstyle.sourceforge.net/releasenotes.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-132) Upgrade to Checkstyle 5.1
Posted by "Bruno Marti (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=229387#action_229387 ]
Bruno Marti commented on MCHECKSTYLE-132:
-----------------------------------------
Who installed checkstyle 5.0 on central repo?
Perhaps this guy can help.
I would really appreciate this improvement in the near future.
> Upgrade to Checkstyle 5.1
> -------------------------
>
> Key: MCHECKSTYLE-132
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-132
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Reporter: Simon Brandhof
>
> [Release notes|http://checkstyle.sourceforge.net/releasenotes.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-132) Upgrade to Checkstyle 5.1
Posted by "Paul Nyheim (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=242223#action_242223 ]
Paul Nyheim commented on MCHECKSTYLE-132:
-----------------------------------------
Did not have time to actually fix them now, but managed to track down the error.
The tests that fail are related to this change in Checkstyle 5.3 (all tests run fine with 5.2)
[changeset:DefaultConfiguration.java|http://checkstyle.hg.sourceforge.net/hgweb/checkstyle/checkstyle/diff/917266ff93a4/src/checkstyle/com/puppycrawl/tools/checkstyle/DefaultConfiguration.java]
As far as I can find out, cacheFile is specified in both min-plugin-config.xml and in sun_checks.xml (with substitution property), and this creates problems due to the previous mentioned change, where the absolute path would be added to the property with a comma to separate them. This obviously fails when trying to create the file...
So the bottom line is that so long that you do not specify e.g. {{cacheFile}} several times in your config, you should be all clear.
I am not sure whether this is in fact a bug with 5.3, or if it is a result of maven-checkstyle-plugin using the Checkstyle API in the wrong way.
> Upgrade to Checkstyle 5.1
> -------------------------
>
> Key: MCHECKSTYLE-132
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-132
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Reporter: Simon Brandhof
> Attachments: checkstyle-5.3.patch
>
>
> [Release notes|http://checkstyle.sourceforge.net/releasenotes.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-132) Upgrade to Checkstyle 5.1
Posted by "Paul Nyheim (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=242205#action_242205 ]
Paul Nyheim commented on MCHECKSTYLE-132:
-----------------------------------------
Indeed 5.1 seems to be missing, but current version is 5.3, and please note that in version 5.2 they changed groupId from checkstyle to com.puppycrawl.tools, as noted in the [Release Notes|http://checkstyle.sourceforge.net/releasenotes.html]
Both 5.2 and 5.3 are present in central repo: [https://repository.sonatype.org/index.html#nexus-search;quick~checkstyle]
> Upgrade to Checkstyle 5.1
> -------------------------
>
> Key: MCHECKSTYLE-132
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-132
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Reporter: Simon Brandhof
>
> [Release notes|http://checkstyle.sourceforge.net/releasenotes.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-132) Upgrade to Checkstyle 5.1
Posted by "Paul Nyheim (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Nyheim updated MCHECKSTYLE-132:
------------------------------------
Attachment: checkstyle-5.3.patch
patch against v2.6 in svn
All tests run green.
> Upgrade to Checkstyle 5.1
> -------------------------
>
> Key: MCHECKSTYLE-132
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-132
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Reporter: Simon Brandhof
> Attachments: checkstyle-5.3.patch
>
>
> [Release notes|http://checkstyle.sourceforge.net/releasenotes.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-132) Upgrade to Checkstyle 5.1
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210691#action_210691 ]
Olivier Lamy commented on MCHECKSTYLE-132:
------------------------------------------
who push this in central repo ? currently it's not in .
> Upgrade to Checkstyle 5.1
> -------------------------
>
> Key: MCHECKSTYLE-132
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-132
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Reporter: Simon Brandhof
>
> [Release notes|http://checkstyle.sourceforge.net/releasenotes.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira