You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/09/29 20:21:02 UTC
[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7497: Follow up to improve restlet API package config key
Jackie-Jiang commented on a change in pull request #7497:
URL: https://github.com/apache/pinot/pull/7497#discussion_r718855195
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -838,7 +840,12 @@ public int getControllerBrokerPortOverride() {
}
public String getControllerResourcePackages() {
- return getProperty(CONTROLLER_RESOURCE_PACKAGES, DEFAULT_CONTROLLER_RESOURCE_PACKAGES);
+ Object rawProperty = getRawProperty(CONTROLLER_RESOURCE_PACKAGES, DEFAULT_CONTROLLER_RESOURCE_PACKAGES);
Review comment:
I think we should fix `getProperty(String name, String defaultValue)` instead of handling it here. `getProperty(String name, String defaultValue)` should return comma separated string instead of `List.toString()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org