You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2010/04/08 19:57:36 UTC
[jira] Created: (LUCENE-2385) Move NoDeletionPolicy from benchmark
to core
Move NoDeletionPolicy from benchmark to core
--------------------------------------------
Key: LUCENE-2385
URL: https://issues.apache.org/jira/browse/LUCENE-2385
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/benchmark, Index
Reporter: Shai Erera
Assignee: Shai Erera
Priority: Trivial
Fix For: 3.1
As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2385) Move NoDeletionPolicy from
benchmark to core
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855150#action_12855150 ]
Uwe Schindler commented on LUCENE-2385:
---------------------------------------
In general we place a list of all svn move/copy command together with the patch, executeable from the root dir. If you paste those commands into your terminal and then apply the patch, it works. One example is the jflex issue (ok, the commands are shortened).
Another possibility is to have a second checkout, where you arrange the files correctly (svn moved/copied) and one for creating the patches.
> Move NoDeletionPolicy from benchmark to core
> --------------------------------------------
>
> Key: LUCENE-2385
> URL: https://issues.apache.org/jira/browse/LUCENE-2385
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark, Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2385.patch
>
>
> As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2385) Move NoDeletionPolicy from
benchmark to core
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855155#action_12855155 ]
Shai Erera commented on LUCENE-2385:
------------------------------------
Forgot to mention that the only move I made was of NoDeletionPolicy:
svn move contrib/benchmark/src/java/org/apache/lucene/benchmark/utils/NoDeletionPolicy.java src/java/org/apache/lucene/index/NoDeletionPolicy.java
I'll remember that in the future Uwe - thanks for the heads up !
> Move NoDeletionPolicy from benchmark to core
> --------------------------------------------
>
> Key: LUCENE-2385
> URL: https://issues.apache.org/jira/browse/LUCENE-2385
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark, Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2385.patch, LUCENE-2385.patch
>
>
> As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2385) Move NoDeletionPolicy from benchmark
to core
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera updated LUCENE-2385:
-------------------------------
Attachment: LUCENE-2385.patch
Move NoDeletionPolicy to core, adds javadocs + TestNoDeletionPolicy. Also includes the relevant changes to benchmark (algorithms + CreateIndexTask).
I've fixed a typo I had in NoMergeScheduler - not related to this issue, but since it was just a typo, thought it's no harm to do it here.
Tests pass. Planning to commit shortly.
> Move NoDeletionPolicy from benchmark to core
> --------------------------------------------
>
> Key: LUCENE-2385
> URL: https://issues.apache.org/jira/browse/LUCENE-2385
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark, Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2385.patch
>
>
> As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2385) Move NoDeletionPolicy from
benchmark to core
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855164#action_12855164 ]
Uwe Schindler commented on LUCENE-2385:
---------------------------------------
Yeah thats fine!
> Move NoDeletionPolicy from benchmark to core
> --------------------------------------------
>
> Key: LUCENE-2385
> URL: https://issues.apache.org/jira/browse/LUCENE-2385
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark, Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2385.patch, LUCENE-2385.patch
>
>
> As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2385) Move NoDeletionPolicy from benchmark
to core
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera resolved LUCENE-2385.
--------------------------------
Resolution: Fixed
Committed revision 932129.
> Move NoDeletionPolicy from benchmark to core
> --------------------------------------------
>
> Key: LUCENE-2385
> URL: https://issues.apache.org/jira/browse/LUCENE-2385
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark, Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2385.patch, LUCENE-2385.patch
>
>
> As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2385) Move NoDeletionPolicy from
benchmark to core
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855140#action_12855140 ]
Shai Erera commented on LUCENE-2385:
------------------------------------
I did that first, but then remembered that when I did that in the past, people were unable to apply my patches, w/o doing the svn move themselves. Anyway, for this file it's not really important I think - a very simple and tiny file, w/ no history to preserve? Is that ok for this file (b/c I have no idea how to do the svn move now ... after I've made all the changes already) :)
> Move NoDeletionPolicy from benchmark to core
> --------------------------------------------
>
> Key: LUCENE-2385
> URL: https://issues.apache.org/jira/browse/LUCENE-2385
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark, Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2385.patch
>
>
> As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2385) Move NoDeletionPolicy from benchmark
to core
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera updated LUCENE-2385:
-------------------------------
Attachment: LUCENE-2385.patch
Is it better now?
> Move NoDeletionPolicy from benchmark to core
> --------------------------------------------
>
> Key: LUCENE-2385
> URL: https://issues.apache.org/jira/browse/LUCENE-2385
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark, Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2385.patch, LUCENE-2385.patch
>
>
> As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2385) Move NoDeletionPolicy from
benchmark to core
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855136#action_12855136 ]
Uwe Schindler commented on LUCENE-2385:
---------------------------------------
The patch does not look like you svn moved the files. To preserve history, you should do a "svn move" of the file in your local repository and then modify it to reflect the package changes (if any).
Did you do this?
> Move NoDeletionPolicy from benchmark to core
> --------------------------------------------
>
> Key: LUCENE-2385
> URL: https://issues.apache.org/jira/browse/LUCENE-2385
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark, Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.1
>
> Attachments: LUCENE-2385.patch
>
>
> As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org