[jira] [Commented] (CAMEL-4058) OnException should overlay settings with existing error handler

["Claus Ibsen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044922#comment-13044922 ] 

Claus Ibsen commented on CAMEL-4058:
------------------------------------

This requires that we add builders in Java DSL / scala DSL so end user can turn on/off
- useOriginalMessage
- asyncDelayedRedelivery
- useCollisionAvoidance
- useExceptionalBackoff

As they dont accept an boolean option to control it. So with overlay they will inheit parent settings, and in case you don't want that you cannot set for example - do not use orignal message. So we need for those 4:

- useOriginalMessage(boolean)
- asyncDelayedRedelivery(boolean)
- useCollisionAvoidance(boolean)
- useExceptionalBackoff(boolean)


> OnException should overlay settings with existing error handler
> ---------------------------------------------------------------
>
>                 Key: CAMEL-4058
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4058
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.7.2
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.8.0
>
>
> See CAMEL-3989
> When you have an OnException it should overlay its configuration with the existing error handler (so its kinda of merge). However we mistakenly set the handled policy from the OnException always, and dont honor the setting from the error handler. So in case of DeadLetterChannel which always handle the exception, it will cause the exception to not be handled and thus rethrown in Camel.
> This problem is only apparent when using the DLC as its the only error handler that handles and moves the exchange to the DLC. The other error handler will log or the likes, but still keep the exception on the exchange to propagated back the exception to the caller.
> So we only noticed this when testing with DLC, and what Hadrian was trying to do in CAMEL-3989

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira