[GitHub] [pinot] cbalci commented on a diff in pull request #10321: Refactor Spark Connector into two modules for reusability

["cbalci (via GitHub)" <gi...@apache.org>]

cbalci commented on code in PR #10321:
URL: https://github.com/apache/pinot/pull/10321#discussion_r1115168268


##########
pinot-connectors/pinot-spark-common/src/main/java/org/apache/pinot/connector/spark/common/CaseInsensitiveStringMap.java:
##########
@@ -0,0 +1,201 @@
+/**

Review Comment:
   `org.apache.spark.sql.sources.v2.DataSourceOptions`, which is used by Spark to contain user specified options is removed in Spark3 in favor of a new and more capable container `CaseInsensitiveStringMap`, which is compatible with `DataSourceOption`. I copied this class from Spark codebase into our 'pinot-spark-common' package as a drop in replacement for the former and reworked the `PinotDataSourceReadOptions` accordingly. Now the options class can be reused by both implementations (v2 and v3) consistently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org