You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/05/10 07:24:28 UTC

[GitHub] eolivelli commented on a change in pull request #1399: Issue #1396: Export metrics in same http server

eolivelli commented on a change in pull request #1399: Issue #1396: Export metrics in same http server
URL: https://github.com/apache/bookkeeper/pull/1399#discussion_r187258749
 
 

 ##########
 File path: bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java
 ##########
 @@ -174,7 +176,7 @@ public StatsLogger getStatsLogger(String scope) {
     }
 
     @VisibleForTesting
-    void writeAllMetrics(Writer writer) throws IOException {
+    public void writeAllMetrics(Writer writer) throws IOException {
 
 Review comment:
   nit:
   This is no more @VisibleForTesting, and it should have @Override

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services