You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/09/13 07:18:48 UTC

[GitHub] [lucene] dweiss opened a new pull request, #11766: Retry gradle wrapper download on http 500 and 503.

dweiss opened a new pull request, #11766:
URL: https://github.com/apache/lucene/pull/11766

   We have more and more frequent CI failures due to http 500 and 503 when downloading the gradle wrapper. I added a simple retry mechanism (compatible with JDK11 for ease of backport) - perhaps it'll limit the failures slightly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] rmuir commented on a diff in pull request #11766: Retry gradle wrapper download on http 500 and 503.

Posted by GitBox <gi...@apache.org>.
rmuir commented on code in PR #11766:
URL: https://github.com/apache/lucene/pull/11766#discussion_r969252828


##########
buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java:
##########
@@ -90,18 +95,34 @@ public void run(Path destination) throws IOException, NoSuchAlgorithmException {
     URL url = new URL("https://github.com/gradle/gradle/raw/v" + wrapperVersion + "/gradle/wrapper/gradle-wrapper.jar");

Review Comment:
   I'd toss in 502 or just retry on any http 5xx? Also we can avoid hitting this URL that's giving trouble, when it works it just redirects us somewhere else anyway?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] dweiss commented on a diff in pull request #11766: Retry gradle wrapper download on http 500 and 503.

Posted by GitBox <gi...@apache.org>.
dweiss commented on code in PR #11766:
URL: https://github.com/apache/lucene/pull/11766#discussion_r969270375


##########
buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java:
##########
@@ -90,18 +95,34 @@ public void run(Path destination) throws IOException, NoSuchAlgorithmException {
     URL url = new URL("https://github.com/gradle/gradle/raw/v" + wrapperVersion + "/gradle/wrapper/gradle-wrapper.jar");

Review Comment:
   Yup. Added 502 and updated the URL. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] dweiss merged pull request #11766: Retry gradle wrapper download on http 500 and 503.

Posted by GitBox <gi...@apache.org>.
dweiss merged PR #11766:
URL: https://github.com/apache/lucene/pull/11766


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] dweiss commented on pull request #11766: Retry gradle wrapper download on http 500 and 503.

Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #11766:
URL: https://github.com/apache/lucene/pull/11766#issuecomment-1246965355

   Darn, I've cherry picked it on branch_9x but didn't push the changes. I've rebased it now and pushed. Sorry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] rmuir commented on pull request #11766: Retry gradle wrapper download on http 500 and 503.

Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11766:
URL: https://github.com/apache/lucene/pull/11766#issuecomment-1246912736

   @dweiss we haven't seen any issues from this commit in jenkins, should be backport to 9.x branch as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org