[GitHub] [zookeeper] hanm edited a comment on issue #1007: ZOOKEEPER-3448: Introduce MessageTracker to assist debug leader and leaner connectivity issues.

[GitBox <gi...@apache.org>]

hanm edited a comment on issue #1007: ZOOKEEPER-3448: Introduce MessageTracker to assist debug leader and leaner connectivity issues.
URL: https://github.com/apache/zookeeper/pull/1007#issuecomment-517488450
 
 
   @lvfangmin 
   
   >> Can you also give an example how this helps tracking the connectivity issue in reality?
   
   The basic idea is to gather additional data to recover the crime scene if the disconnection happens. A concrete example is, when an observer disconnects from leader, we want to know if it's because observer did not send PING at all to observer master (e.g. stop the world GC before it had a chance to send out PING before socket timed out), or the observer did send out the PING but the packet lost (network issue). Being able to peek the last set of packets on both sender and receiver side can provide additional insights when reasoning about disconnection events.
   
   >> we should probably merge the idea of MessageTracker and the improved ZooTrace in ZOOKEEPER-3432 later.
   
   Yes, the message tracker is a very specific solution to a very specific problem (disconnections between servers). Tracing is a more generalized framework that should be able to provide similar insights to this case, and many more, though because of generalization it requires significant more effort to implement.
   I'll definitely check out the pending PR related to tracing work and provide my feedback there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services