You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/26 06:33:05 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #380: arm: Fix
"make export" for KERNEL build
yamt opened a new pull request #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #380: arm: Fix "make
export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-593761349
@xiaoxiang781216 my understanding is that it isn't appropriate to add crt0.c to CMN_CSRCS as it's for kernel sources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #380: arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385610442
##########
File path: arch/arm/src/Makefile
##########
@@ -80,6 +80,10 @@ endif
# The "head" object
HEAD_OBJ = $(HEAD_ASRC:.S=$(OBJEXT))
+ifneq ($(STARTUP_OBJS),)
+ # Assume C by default
+ STARTUP_COBJS ?= $(STARTUP_OBJS)
+endif
STARTUP_OBJS ?= $(HEAD_OBJ)
Review comment:
> well, for non-KERNEL builds, "linking apps" involves the whole kernel, doesn't it?
Yes, if apps is built into kernel. But if we build apps as elf binary, it is separated from kernel totally.
> anyway, it's entirely possible i don't understand "make export" is. i haven't successfully used it. i tried it just because it was in the procedure in sema5 README.
I also don't use export before, from my understanding: export is used for 3rd party develop application without full nuttx source code(something like Android NDK).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #380: arm: Fix "make
export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-591428093
Please merge when the conversation is resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #380: arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r384311198
##########
File path: arch/arm/src/Makefile
##########
@@ -80,6 +80,10 @@ endif
# The "head" object
HEAD_OBJ = $(HEAD_ASRC:.S=$(OBJEXT))
+ifneq ($(STARTUP_OBJS),)
+ # Assume C by default
+ STARTUP_COBJS ?= $(STARTUP_OBJS)
+endif
STARTUP_OBJS ?= $(HEAD_OBJ)
Review comment:
How about we remove line 83 to 87, and put $(STARTUP_OBJS) to line 175 directly? it doesn't make sense to assign HEAD_OBJ to STARTUP_OBJS if it is empty because HEAD_OBJ is for kernel startup and never suitable for userspace startup.
Also, we need modify other arch to ensure crt0.c get compiled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #380: arm: Fix
"make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-593754685
@yamt could you review the new change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #380:
arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385595813
##########
File path: arch/arm/src/Makefile
##########
@@ -80,6 +80,10 @@ endif
# The "head" object
HEAD_OBJ = $(HEAD_ASRC:.S=$(OBJEXT))
+ifneq ($(STARTUP_OBJS),)
+ # Assume C by default
+ STARTUP_COBJS ?= $(STARTUP_OBJS)
+endif
STARTUP_OBJS ?= $(HEAD_OBJ)
Review comment:
anyway, it's entirely possible i don't understand "make export" is. i haven't successfully used it. i tried it just because it was in the procedure in sema5 README.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #380: arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r384426713
##########
File path: arch/arm/src/Makefile
##########
@@ -80,6 +80,10 @@ endif
# The "head" object
HEAD_OBJ = $(HEAD_ASRC:.S=$(OBJEXT))
+ifneq ($(STARTUP_OBJS),)
+ # Assume C by default
+ STARTUP_COBJS ?= $(STARTUP_OBJS)
+endif
STARTUP_OBJS ?= $(HEAD_OBJ)
Review comment:
All HEAD_ASRC has the code to initialize the whole system, it's always not suitable as raw application enrty point in any build mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #380: arm: Fix
"make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-593770744
> @xiaoxiang781216 what ensures UOBJS built before STARTUP_OBJS is being used?
export_startup depend on STARTUP_OBJS, so it isn't an issue, but UOBJS will be archived libuarch.a which mayn't what we want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #380:
arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385582063
##########
File path: arch/arm/src/Makefile
##########
@@ -80,6 +80,10 @@ endif
# The "head" object
HEAD_OBJ = $(HEAD_ASRC:.S=$(OBJEXT))
+ifneq ($(STARTUP_OBJS),)
+ # Assume C by default
+ STARTUP_COBJS ?= $(STARTUP_OBJS)
+endif
STARTUP_OBJS ?= $(HEAD_OBJ)
Review comment:
my understanding/assumption was that:
* the export target is to collect things necessary to build and link apps
* in case of non-KERNEL builds, it can includes HEAD_OBJ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #380: arm: Fix
"make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-593762190
> @xiaoxiang781216 my understanding is that it isn't appropriate to add crt0.c to CMN_CSRCS as it's for kernel sources.
Good point, I will change to CMN_UCSRCS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #380: arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385589116
##########
File path: arch/arm/src/Makefile
##########
@@ -80,6 +80,10 @@ endif
# The "head" object
HEAD_OBJ = $(HEAD_ASRC:.S=$(OBJEXT))
+ifneq ($(STARTUP_OBJS),)
+ # Assume C by default
+ STARTUP_COBJS ?= $(STARTUP_OBJS)
+endif
STARTUP_OBJS ?= $(HEAD_OBJ)
Review comment:
> my understanding/assumption was that:
>
> * the export target is to collect things necessary to build and link apps
Yes, export target is just for apps initialization.
> * in case of non-KERNEL builds, it can includes HEAD_OBJ
No, because HEAD_OBJ contain the machine start up code, launching apps linked with HEAD_OBJ most likely will generate the panic in any build mode. Can you imagine the result that HEAD_OBJ code(initialize the machine) run more than once?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #380: arm: Fix "make
export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-593767980
@xiaoxiang781216 what ensures UOBJS built before STARTUP_OBJS is being used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #380:
arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385594289
##########
File path: arch/arm/src/Makefile
##########
@@ -80,6 +80,10 @@ endif
# The "head" object
HEAD_OBJ = $(HEAD_ASRC:.S=$(OBJEXT))
+ifneq ($(STARTUP_OBJS),)
+ # Assume C by default
+ STARTUP_COBJS ?= $(STARTUP_OBJS)
+endif
STARTUP_OBJS ?= $(HEAD_OBJ)
Review comment:
well, for non-KERNEL builds, "linking apps" involves the whole kernel, doesn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #380:
arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #380: arm: Fix "make export" for KERNEL build
URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r384319612
##########
File path: arch/arm/src/Makefile
##########
@@ -80,6 +80,10 @@ endif
# The "head" object
HEAD_OBJ = $(HEAD_ASRC:.S=$(OBJEXT))
+ifneq ($(STARTUP_OBJS),)
+ # Assume C by default
+ STARTUP_COBJS ?= $(STARTUP_OBJS)
+endif
STARTUP_OBJS ?= $(HEAD_OBJ)
Review comment:
isn't it necessary for non KERNEL configs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] v01d commented on pull request #380: arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #380:
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-691682813
@yamt could you fill the PR description. We can leave this open to indicate the solution needs testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #380: arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #380:
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-635647655
@yamt @xiaoxiang781216 Can we close this PR? it is almost four months old and there have been no updates or comments for almost three months now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #380: arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #380:
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-637410662
@yamt please comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #380: arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #380:
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-637448228
i guess the problem still exists. but i'm not looking at KERNEL build these days. it's great if someone more familiar with KERNEL build can take this over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #380: arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #380:
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-635647655
Can we close this PR? it is over three months old and there have been no updates or comments for almost two months now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #380: arm: Fix "make export" for KERNEL build
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #380:
URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-635647655
Can we close this PR? it is almost four months old and there have been no updates or comments for almost three months now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org