[GitHub] [spark] mgaido91 commented on a change in pull request #25261: [SPARK-28521][SQL] Fix error message for built-in functions

[GitBox <gi...@apache.org>]

mgaido91 commented on a change in pull request #25261: [SPARK-28521][SQL] Fix error message for built-in functions
URL: https://github.com/apache/spark/pull/25261#discussion_r307716730
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
 ##########
 @@ -586,8 +586,9 @@ object FunctionRegistry {
         val params = Seq.fill(expressions.size)(classOf[Expression])
         val f = constructors.find(_.getParameterTypes.toSeq == params).getOrElse {
 
 Review comment:
   but here we're still filtering by expressions..am I missing something?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org