You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Daniel Keir Haywood (Jira)" <ji...@apache.org> on 2020/01/01 14:07:00 UTC

[jira] [Commented] (ISIS-2065) Allow homePageService to specify the homePage without the workaround of setting its nature to VIEW_CONTRIBUTIONS_ONLY

    [ https://issues.apache.org/jira/browse/ISIS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006412#comment-17006412 ] 

Daniel Keir Haywood commented on ISIS-2065:
-------------------------------------------

This is fixed in 2.0.0, eg
{code:java}
@Service
@Named("domainapp.HomePageService")
public class HomePageService {

    private final FactoryService factoryService;

    @Inject
    public HomePageService(final FactoryService factoryService) {
        this.factoryService = factoryService;
    }

    @Action(semantics = SemanticsOf.SAFE)
    @HomePage
    public HomePageViewModel homePage() {
        return factoryService.instantiate(HomePageViewModel.class);
    }

} {code}

> Allow homePageService to specify the homePage without the workaround of setting its nature to VIEW_CONTRIBUTIONS_ONLY
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-2065
>                 URL: https://issues.apache.org/jira/browse/ISIS-2065
>             Project: Isis
>          Issue Type: Improvement
>            Reporter: Maré du Preez
>            Priority: Minor
>             Fix For: 1.18.0
>
>
> Contributed actions will be removed in 2.0, and can be disabled, however they are used as a workaround for HomePageService to advertise an action to be invoked to return the homePage but nevertheless to not  be rendered in the menu.
> ~~~
> Improve the viewing for WickedCharts. At the moment, if you set the nature of a WickedChart object to VIEW_MENU_ONLY, it has the side effect of having an unnecessary menu item appear.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)