You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/09 07:57:03 UTC
[GitHub] [ignite-3] xtern commented on a diff in pull request #1416: IGNITE-18224 Sql. Allow hash output distribution for SET relations.
xtern commented on code in PR #1416:
URL: https://github.com/apache/ignite-3/pull/1416#discussion_r1044178634
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/SetOpPlannerTest.java:
##########
@@ -70,10 +74,48 @@ public void setup() {
createTable(publicSchema, "SINGLE_TBL2", type, IgniteDistributions.single());
createTable(publicSchema, "AFFINITY_TBL1", type,
- IgniteDistributions.affinity(0, "Test1", "hash"));
+ // TODO https://issues.apache.org/jira/browse/IGNITE-18211
+ // IgniteDistributions.affinity(0, "Test1", "hash"));
+ IgniteDistributions.hash(List.of(0)));
+
createTable(publicSchema, "AFFINITY_TBL2", type,
- IgniteDistributions.affinity(0, "Test2", "hash"));
+ // TODO https://issues.apache.org/jira/browse/IGNITE-18211
+ // IgniteDistributions.affinity(0, "Test2", "hash"));
+ IgniteDistributions.hash(List.of(0)));
+
+ createTable(publicSchema, "AFFINITY_TBL3", type,
+ IgniteDistributions.affinity(1, "Test3", "hash"));
+
+ createTable(publicSchema, "AFFINITY_TBL4", type,
+ IgniteDistributions.affinity(0, "Test4", "hash2"));
+ }
+
+ /**
+ * testSetOpAffinityNested
+ * TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
Review Comment:
Done
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/set/IgniteColocatedIntersect.java:
##########
@@ -43,20 +43,20 @@ public IgniteSingleIntersect(
* Constructor.
* TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org