You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/02/24 02:42:39 UTC

[GitHub] wu-sheng opened a new pull request #2288: [WIP]Improve OAP extendibility

wu-sheng opened a new pull request #2288: [WIP]Improve OAP extendibility
URL: https://github.com/apache/incubator-skywalking/pull/2288
 
 
   The reason I am doing this refactoring is, making the extendibility OAP server better.
   
   The core change is ** REMOVING Scope enum type restrictions**. As we all known, Enum in Java could be inherited, when could anyone wants to create a new scope, the only choice only changes the source codes, include `enum Scope` and generation-tool.
   
   So I am doing following changes
   1. Make Scope(name-id) declaration as annotation, like this `@ScopeDeclaration(id = SERVICE, name = "Service")`. This annotation is Repeatable, so you could declare any new scope in any class in `org.apache.skywalking` package.
   1. Scope enum removed.
   1. Scope in `@StorageEntity` has been changed to `sourceScopeId`.
   
   Also, I do some changes for OAL generation-tool.
   1. Support the above changes.
   1. TODO in this pr, make `dispatcher template` extendable too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services