You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zanmato1984 (via GitHub)" <gi...@apache.org> on 2024/09/19 03:02:54 UTC
[PR] Add more row segmenter tests [arrow]
zanmato1984 opened a new pull request, #44166:
URL: https://github.com/apache/arrow/pull/44166
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44166:
URL: https://github.com/apache/arrow/pull/44166#discussion_r1766568861
##########
cpp/src/arrow/acero/hash_aggregate_test.cc:
##########
@@ -804,64 +804,143 @@ TEST(RowSegmenter, MultipleSegmentsMultipleBatches) {
namespace {
void TestRowSegmenterConstantBatch(
- std::function<ArgShape(size_t i)> shape_func,
+ const std::shared_ptr<DataType>& type,
+ std::function<ArgShape(int64_t key)> shape_func,
+ std::function<Result<std::shared_ptr<Scalar>>(int64_t key)> value_func,
std::function<Result<std::unique_ptr<RowSegmenter>>(const std::vector<TypeHolder>&)>
make_segmenter) {
- constexpr size_t n = 3, repetitions = 3;
- std::vector<TypeHolder> types = {int32(), int32(), int32()};
- std::vector<ArgShape> shapes(n);
- for (size_t i = 0; i < n; i++) shapes[i] = shape_func(i);
- auto full_batch = ExecBatchFromJSON(types, shapes, "[[1, 1, 1], [1, 1, 1], [1, 1, 1]]");
- auto test_by_size = [&](size_t size) -> Status {
- SCOPED_TRACE("constant-batch with " + ToChars(size) + " key(s)");
- std::vector<Datum> values(full_batch.values.begin(),
- full_batch.values.begin() + size);
- ExecBatch batch(values, full_batch.length);
- std::vector<TypeHolder> key_types(types.begin(), types.begin() + size);
+ constexpr int64_t n_keys = 3, n_rows = 3, repetitions = 3;
+ std::vector<TypeHolder> types(n_keys, type);
+ std::vector<Datum> full_values(n_keys);
+ for (int64_t i = 0; i < n_keys; i++) {
+ auto shape = shape_func(i);
+ ASSERT_OK_AND_ASSIGN(auto scalar, value_func(i));
+ if (shape == ArgShape::SCALAR) {
+ full_values[i] = std::move(scalar);
+ } else {
+ ASSERT_OK_AND_ASSIGN(full_values[i], MakeArrayFromScalar(*scalar, n_rows));
+ }
+ }
+ auto test_with_keys = [&](int64_t keys) -> Status {
+ SCOPED_TRACE("constant-batch with " + ToChars(keys) + " key(s)");
+ std::vector<Datum> values(full_values.begin(), full_values.begin() + keys);
+ ExecBatch batch(values, n_rows);
+ std::vector<TypeHolder> key_types(types.begin(), types.begin() + keys);
ARROW_ASSIGN_OR_RAISE(auto segmenter, make_segmenter(key_types));
- for (size_t i = 0; i < repetitions; i++) {
- TestSegments(segmenter, ExecSpan(batch), {{0, 3, true, true}});
+ for (int64_t i = 0; i < repetitions; i++) {
+ TestSegments(segmenter, ExecSpan(batch), {{0, n_rows, true, true}});
ARROW_RETURN_NOT_OK(segmenter->Reset());
}
return Status::OK();
};
- for (size_t i = 0; i <= 3; i++) {
- ASSERT_OK(test_by_size(i));
+ for (int64_t i = 0; i <= n_keys; i++) {
+ ASSERT_OK(test_with_keys(i));
}
}
} // namespace
TEST(RowSegmenter, ConstantArrayBatch) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::ARRAY; },
- MakeRowSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantScalarBatch) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::SCALAR; },
- MakeRowSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::SCALAR; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantMixedBatch) {
TestRowSegmenterConstantBatch(
- [](size_t i) { return i % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
- MakeRowSegmenter);
+ int32(),
+ [](int64_t key) { return key % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantArrayBatchWithAnyKeysSegmenter) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::ARRAY; },
- MakeGenericSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
}
TEST(RowSegmenter, ConstantScalarBatchWithAnyKeysSegmenter) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::SCALAR; },
- MakeGenericSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::SCALAR; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
}
TEST(RowSegmenter, ConstantMixedBatchWithAnyKeysSegmenter) {
TestRowSegmenterConstantBatch(
- [](size_t i) { return i % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
- MakeGenericSegmenter);
+ int32(),
+ [](int64_t key) { return key % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
+}
+
+TEST(RowSegmenter, ConstantFixedSizeBinaryArrayBatch) {
+ constexpr int fsb = 8;
+ auto type = fixed_size_binary(fsb);
+ ASSERT_OK_AND_ASSIGN(auto value, MakeScalar(type, std::string(fsb, 'X')));
+ TestRowSegmenterConstantBatch(
+ type, [](int64_t key) { return ArgShape::ARRAY; },
+ [&](int64_t key) { return value; }, MakeRowSegmenter);
Review Comment:
Should these additional tests also exercise `MakeGenericSegmenter`? Or is that covered elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44166:
URL: https://github.com/apache/arrow/pull/44166#discussion_r1771741323
##########
cpp/src/arrow/acero/hash_aggregate_test.cc:
##########
@@ -759,11 +741,22 @@ TEST(RowSegmenter, MultipleSegments) {
{4, 2, false, false},
{6, 2, false, false},
{8, 1, true, false}});
+ };
+ for (int num_keys = 1; num_keys <= 2; ++num_keys) {
+ test_with_keys(num_keys, ArrayFromJSON(int32(), "[1, 1, 2, 5, 3, 3, 5, 5, 4]"));
+ test_with_keys(
+ num_keys,
+ ArrayFromJSON(fixed_size_binary(2),
+ R"(["aa", "aa", "bb", "ee", "cc", "cc", "ee", "ee", "dd"])"));
+ test_with_keys(num_keys, DictArrayFromJSON(dictionary(int8(), utf8()),
+ "[0, 0, 1, 4, 2, 2, 4, 4, 3]",
+ R"(["a", "b", "c", "d", "e"])"));
Review Comment:
Great, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more row segmenter tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44166:
URL: https://github.com/apache/arrow/pull/44166#issuecomment-2359881894
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #44166:
URL: https://github.com/apache/arrow/pull/44166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #44166:
URL: https://github.com/apache/arrow/pull/44166#discussion_r1771410904
##########
cpp/src/arrow/acero/hash_aggregate_test.cc:
##########
@@ -759,11 +741,22 @@ TEST(RowSegmenter, MultipleSegments) {
{4, 2, false, false},
{6, 2, false, false},
{8, 1, true, false}});
+ };
+ for (int num_keys = 1; num_keys <= 2; ++num_keys) {
+ test_with_keys(num_keys, ArrayFromJSON(int32(), "[1, 1, 2, 5, 3, 3, 5, 5, 4]"));
+ test_with_keys(
+ num_keys,
+ ArrayFromJSON(fixed_size_binary(2),
+ R"(["aa", "aa", "bb", "ee", "cc", "cc", "ee", "ee", "dd"])"));
+ test_with_keys(num_keys, DictArrayFromJSON(dictionary(int8(), utf8()),
+ "[0, 0, 1, 4, 2, 2, 4, 4, 3]",
+ R"(["a", "b", "c", "d", "e"])"));
Review Comment:
FYI @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #44166:
URL: https://github.com/apache/arrow/pull/44166#issuecomment-2363335872
> > Using const batch is just a way to minimize the code for exercising the combinations of data types x column shapes. And I guess using non-constant batch doesn't add more coverage on that.
>
> A non-constant batch (even with only two distinct values) would ensure the segmenting actually works :-)
Makes sense. I'll see how to enhance this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #44166:
URL: https://github.com/apache/arrow/pull/44166#discussion_r1768328406
##########
cpp/src/arrow/acero/hash_aggregate_test.cc:
##########
@@ -804,64 +804,143 @@ TEST(RowSegmenter, MultipleSegmentsMultipleBatches) {
namespace {
void TestRowSegmenterConstantBatch(
- std::function<ArgShape(size_t i)> shape_func,
+ const std::shared_ptr<DataType>& type,
+ std::function<ArgShape(int64_t key)> shape_func,
+ std::function<Result<std::shared_ptr<Scalar>>(int64_t key)> value_func,
std::function<Result<std::unique_ptr<RowSegmenter>>(const std::vector<TypeHolder>&)>
make_segmenter) {
- constexpr size_t n = 3, repetitions = 3;
- std::vector<TypeHolder> types = {int32(), int32(), int32()};
- std::vector<ArgShape> shapes(n);
- for (size_t i = 0; i < n; i++) shapes[i] = shape_func(i);
- auto full_batch = ExecBatchFromJSON(types, shapes, "[[1, 1, 1], [1, 1, 1], [1, 1, 1]]");
- auto test_by_size = [&](size_t size) -> Status {
- SCOPED_TRACE("constant-batch with " + ToChars(size) + " key(s)");
- std::vector<Datum> values(full_batch.values.begin(),
- full_batch.values.begin() + size);
- ExecBatch batch(values, full_batch.length);
- std::vector<TypeHolder> key_types(types.begin(), types.begin() + size);
+ constexpr int64_t n_keys = 3, n_rows = 3, repetitions = 3;
+ std::vector<TypeHolder> types(n_keys, type);
+ std::vector<Datum> full_values(n_keys);
+ for (int64_t i = 0; i < n_keys; i++) {
+ auto shape = shape_func(i);
+ ASSERT_OK_AND_ASSIGN(auto scalar, value_func(i));
+ if (shape == ArgShape::SCALAR) {
+ full_values[i] = std::move(scalar);
+ } else {
+ ASSERT_OK_AND_ASSIGN(full_values[i], MakeArrayFromScalar(*scalar, n_rows));
+ }
+ }
+ auto test_with_keys = [&](int64_t keys) -> Status {
+ SCOPED_TRACE("constant-batch with " + ToChars(keys) + " key(s)");
+ std::vector<Datum> values(full_values.begin(), full_values.begin() + keys);
+ ExecBatch batch(values, n_rows);
+ std::vector<TypeHolder> key_types(types.begin(), types.begin() + keys);
ARROW_ASSIGN_OR_RAISE(auto segmenter, make_segmenter(key_types));
- for (size_t i = 0; i < repetitions; i++) {
- TestSegments(segmenter, ExecSpan(batch), {{0, 3, true, true}});
+ for (int64_t i = 0; i < repetitions; i++) {
+ TestSegments(segmenter, ExecSpan(batch), {{0, n_rows, true, true}});
ARROW_RETURN_NOT_OK(segmenter->Reset());
}
return Status::OK();
};
- for (size_t i = 0; i <= 3; i++) {
- ASSERT_OK(test_by_size(i));
+ for (int64_t i = 0; i <= n_keys; i++) {
+ ASSERT_OK(test_with_keys(i));
}
}
} // namespace
TEST(RowSegmenter, ConstantArrayBatch) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::ARRAY; },
- MakeRowSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantScalarBatch) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::SCALAR; },
- MakeRowSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::SCALAR; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantMixedBatch) {
TestRowSegmenterConstantBatch(
- [](size_t i) { return i % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
- MakeRowSegmenter);
+ int32(),
+ [](int64_t key) { return key % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantArrayBatchWithAnyKeysSegmenter) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::ARRAY; },
- MakeGenericSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
}
TEST(RowSegmenter, ConstantScalarBatchWithAnyKeysSegmenter) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::SCALAR; },
- MakeGenericSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::SCALAR; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
}
TEST(RowSegmenter, ConstantMixedBatchWithAnyKeysSegmenter) {
TestRowSegmenterConstantBatch(
- [](size_t i) { return i % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
- MakeGenericSegmenter);
+ int32(),
+ [](int64_t key) { return key % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
+}
+
+TEST(RowSegmenter, ConstantFixedSizeBinaryArrayBatch) {
+ constexpr int fsb = 8;
+ auto type = fixed_size_binary(fsb);
+ ASSERT_OK_AND_ASSIGN(auto value, MakeScalar(type, std::string(fsb, 'X')));
+ TestRowSegmenterConstantBatch(
+ type, [](int64_t key) { return ArgShape::ARRAY; },
+ [&](int64_t key) { return value; }, MakeRowSegmenter);
Review Comment:
Hmm, right. Will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #44166:
URL: https://github.com/apache/arrow/pull/44166#issuecomment-2360752181
> Are there tests with non-constant input too?
There are individual tests with non-constant input, but they all assume `int32` "array". So in terms of combinations of various data types x column shapes, no there are not.
But I assume the tests being touched in this PR are just the ones to complement this part. Using const batch is just a way to minimize the code for exercising the combinations of data types x column shapes. And I guess using non-constant batch doesn't add more coverage on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #44166:
URL: https://github.com/apache/arrow/pull/44166#discussion_r1766686924
##########
cpp/src/arrow/acero/hash_aggregate_test.cc:
##########
@@ -804,64 +804,143 @@ TEST(RowSegmenter, MultipleSegmentsMultipleBatches) {
namespace {
void TestRowSegmenterConstantBatch(
- std::function<ArgShape(size_t i)> shape_func,
+ const std::shared_ptr<DataType>& type,
+ std::function<ArgShape(int64_t key)> shape_func,
+ std::function<Result<std::shared_ptr<Scalar>>(int64_t key)> value_func,
std::function<Result<std::unique_ptr<RowSegmenter>>(const std::vector<TypeHolder>&)>
make_segmenter) {
- constexpr size_t n = 3, repetitions = 3;
- std::vector<TypeHolder> types = {int32(), int32(), int32()};
- std::vector<ArgShape> shapes(n);
- for (size_t i = 0; i < n; i++) shapes[i] = shape_func(i);
- auto full_batch = ExecBatchFromJSON(types, shapes, "[[1, 1, 1], [1, 1, 1], [1, 1, 1]]");
- auto test_by_size = [&](size_t size) -> Status {
- SCOPED_TRACE("constant-batch with " + ToChars(size) + " key(s)");
- std::vector<Datum> values(full_batch.values.begin(),
- full_batch.values.begin() + size);
- ExecBatch batch(values, full_batch.length);
- std::vector<TypeHolder> key_types(types.begin(), types.begin() + size);
+ constexpr int64_t n_keys = 3, n_rows = 3, repetitions = 3;
+ std::vector<TypeHolder> types(n_keys, type);
+ std::vector<Datum> full_values(n_keys);
+ for (int64_t i = 0; i < n_keys; i++) {
+ auto shape = shape_func(i);
+ ASSERT_OK_AND_ASSIGN(auto scalar, value_func(i));
+ if (shape == ArgShape::SCALAR) {
+ full_values[i] = std::move(scalar);
+ } else {
+ ASSERT_OK_AND_ASSIGN(full_values[i], MakeArrayFromScalar(*scalar, n_rows));
+ }
+ }
+ auto test_with_keys = [&](int64_t keys) -> Status {
+ SCOPED_TRACE("constant-batch with " + ToChars(keys) + " key(s)");
+ std::vector<Datum> values(full_values.begin(), full_values.begin() + keys);
+ ExecBatch batch(values, n_rows);
+ std::vector<TypeHolder> key_types(types.begin(), types.begin() + keys);
ARROW_ASSIGN_OR_RAISE(auto segmenter, make_segmenter(key_types));
- for (size_t i = 0; i < repetitions; i++) {
- TestSegments(segmenter, ExecSpan(batch), {{0, 3, true, true}});
+ for (int64_t i = 0; i < repetitions; i++) {
+ TestSegments(segmenter, ExecSpan(batch), {{0, n_rows, true, true}});
ARROW_RETURN_NOT_OK(segmenter->Reset());
}
return Status::OK();
};
- for (size_t i = 0; i <= 3; i++) {
- ASSERT_OK(test_by_size(i));
+ for (int64_t i = 0; i <= n_keys; i++) {
+ ASSERT_OK(test_with_keys(i));
}
}
} // namespace
TEST(RowSegmenter, ConstantArrayBatch) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::ARRAY; },
- MakeRowSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantScalarBatch) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::SCALAR; },
- MakeRowSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::SCALAR; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantMixedBatch) {
TestRowSegmenterConstantBatch(
- [](size_t i) { return i % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
- MakeRowSegmenter);
+ int32(),
+ [](int64_t key) { return key % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantArrayBatchWithAnyKeysSegmenter) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::ARRAY; },
- MakeGenericSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
}
TEST(RowSegmenter, ConstantScalarBatchWithAnyKeysSegmenter) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::SCALAR; },
- MakeGenericSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::SCALAR; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
}
TEST(RowSegmenter, ConstantMixedBatchWithAnyKeysSegmenter) {
TestRowSegmenterConstantBatch(
- [](size_t i) { return i % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
- MakeGenericSegmenter);
+ int32(),
+ [](int64_t key) { return key % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
+}
+
+TEST(RowSegmenter, ConstantFixedSizeBinaryArrayBatch) {
+ constexpr int fsb = 8;
+ auto type = fixed_size_binary(fsb);
+ ASSERT_OK_AND_ASSIGN(auto value, MakeScalar(type, std::string(fsb, 'X')));
+ TestRowSegmenterConstantBatch(
+ type, [](int64_t key) { return ArgShape::ARRAY; },
+ [&](int64_t key) { return value; }, MakeRowSegmenter);
Review Comment:
I was thinking `MakeRowSegmenter` is the real-world one, so beyond that it might be a little over-tested. But I'm also OK adding coverage for `MakeGenericSegmenter` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #44166:
URL: https://github.com/apache/arrow/pull/44166#discussion_r1771390113
##########
cpp/src/arrow/acero/hash_aggregate_test.cc:
##########
@@ -804,64 +804,143 @@ TEST(RowSegmenter, MultipleSegmentsMultipleBatches) {
namespace {
void TestRowSegmenterConstantBatch(
- std::function<ArgShape(size_t i)> shape_func,
+ const std::shared_ptr<DataType>& type,
+ std::function<ArgShape(int64_t key)> shape_func,
+ std::function<Result<std::shared_ptr<Scalar>>(int64_t key)> value_func,
std::function<Result<std::unique_ptr<RowSegmenter>>(const std::vector<TypeHolder>&)>
make_segmenter) {
- constexpr size_t n = 3, repetitions = 3;
- std::vector<TypeHolder> types = {int32(), int32(), int32()};
- std::vector<ArgShape> shapes(n);
- for (size_t i = 0; i < n; i++) shapes[i] = shape_func(i);
- auto full_batch = ExecBatchFromJSON(types, shapes, "[[1, 1, 1], [1, 1, 1], [1, 1, 1]]");
- auto test_by_size = [&](size_t size) -> Status {
- SCOPED_TRACE("constant-batch with " + ToChars(size) + " key(s)");
- std::vector<Datum> values(full_batch.values.begin(),
- full_batch.values.begin() + size);
- ExecBatch batch(values, full_batch.length);
- std::vector<TypeHolder> key_types(types.begin(), types.begin() + size);
+ constexpr int64_t n_keys = 3, n_rows = 3, repetitions = 3;
+ std::vector<TypeHolder> types(n_keys, type);
+ std::vector<Datum> full_values(n_keys);
+ for (int64_t i = 0; i < n_keys; i++) {
+ auto shape = shape_func(i);
+ ASSERT_OK_AND_ASSIGN(auto scalar, value_func(i));
+ if (shape == ArgShape::SCALAR) {
+ full_values[i] = std::move(scalar);
+ } else {
+ ASSERT_OK_AND_ASSIGN(full_values[i], MakeArrayFromScalar(*scalar, n_rows));
+ }
+ }
+ auto test_with_keys = [&](int64_t keys) -> Status {
+ SCOPED_TRACE("constant-batch with " + ToChars(keys) + " key(s)");
+ std::vector<Datum> values(full_values.begin(), full_values.begin() + keys);
+ ExecBatch batch(values, n_rows);
+ std::vector<TypeHolder> key_types(types.begin(), types.begin() + keys);
ARROW_ASSIGN_OR_RAISE(auto segmenter, make_segmenter(key_types));
- for (size_t i = 0; i < repetitions; i++) {
- TestSegments(segmenter, ExecSpan(batch), {{0, 3, true, true}});
+ for (int64_t i = 0; i < repetitions; i++) {
+ TestSegments(segmenter, ExecSpan(batch), {{0, n_rows, true, true}});
ARROW_RETURN_NOT_OK(segmenter->Reset());
}
return Status::OK();
};
- for (size_t i = 0; i <= 3; i++) {
- ASSERT_OK(test_by_size(i));
+ for (int64_t i = 0; i <= n_keys; i++) {
+ ASSERT_OK(test_with_keys(i));
}
}
} // namespace
TEST(RowSegmenter, ConstantArrayBatch) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::ARRAY; },
- MakeRowSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantScalarBatch) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::SCALAR; },
- MakeRowSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::SCALAR; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantMixedBatch) {
TestRowSegmenterConstantBatch(
- [](size_t i) { return i % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
- MakeRowSegmenter);
+ int32(),
+ [](int64_t key) { return key % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantArrayBatchWithAnyKeysSegmenter) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::ARRAY; },
- MakeGenericSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
}
TEST(RowSegmenter, ConstantScalarBatchWithAnyKeysSegmenter) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::SCALAR; },
- MakeGenericSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::SCALAR; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
}
TEST(RowSegmenter, ConstantMixedBatchWithAnyKeysSegmenter) {
TestRowSegmenterConstantBatch(
- [](size_t i) { return i % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
- MakeGenericSegmenter);
+ int32(),
+ [](int64_t key) { return key % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
+}
+
+TEST(RowSegmenter, ConstantFixedSizeBinaryArrayBatch) {
+ constexpr int fsb = 8;
+ auto type = fixed_size_binary(fsb);
+ ASSERT_OK_AND_ASSIGN(auto value, MakeScalar(type, std::string(fsb, 'X')));
+ TestRowSegmenterConstantBatch(
+ type, [](int64_t key) { return ArgShape::ARRAY; },
+ [&](int64_t key) { return value; }, MakeRowSegmenter);
Review Comment:
Added `MakeGenericSegmenter` cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44166:
URL: https://github.com/apache/arrow/pull/44166#issuecomment-2368762683
CI failures are unrelated, let's merge :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #44166:
URL: https://github.com/apache/arrow/pull/44166#discussion_r1771409502
##########
cpp/src/arrow/acero/hash_aggregate_test.cc:
##########
@@ -759,11 +741,22 @@ TEST(RowSegmenter, MultipleSegments) {
{4, 2, false, false},
{6, 2, false, false},
{8, 1, true, false}});
+ };
+ for (int num_keys = 1; num_keys <= 2; ++num_keys) {
+ test_with_keys(num_keys, ArrayFromJSON(int32(), "[1, 1, 2, 5, 3, 3, 5, 5, 4]"));
+ test_with_keys(
+ num_keys,
+ ArrayFromJSON(fixed_size_binary(2),
+ R"(["aa", "aa", "bb", "ee", "cc", "cc", "ee", "ee", "dd"])"));
+ test_with_keys(num_keys, DictArrayFromJSON(dictionary(int8(), utf8()),
+ "[0, 0, 1, 4, 2, 2, 4, 4, 3]",
+ R"(["a", "b", "c", "d", "e"])"));
Review Comment:
I added the "non-constant batch" cases here instead of `TestRowSegmenterConstantBatch`. Because `TestRowSegmenterConstantBatch` tests scalars which are by definition cannot be "non-constant".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44166:
URL: https://github.com/apache/arrow/pull/44166#issuecomment-2369817048
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c42df5fcd3532df26cf2a7fa5404e16701f25bc6.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/30555409073) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44166:
URL: https://github.com/apache/arrow/pull/44166#issuecomment-2360796752
> Using const batch is just a way to minimize the code for exercising the combinations of data types x column shapes. And I guess using non-constant batch doesn't add more coverage on that.
A non-constant batch (even with only two distinct values) would ensure the segmenting actually works :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #44166:
URL: https://github.com/apache/arrow/pull/44166#issuecomment-2360585261
Are there tests with non-constant input too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44166:
URL: https://github.com/apache/arrow/pull/44166#discussion_r1766703208
##########
cpp/src/arrow/acero/hash_aggregate_test.cc:
##########
@@ -804,64 +804,143 @@ TEST(RowSegmenter, MultipleSegmentsMultipleBatches) {
namespace {
void TestRowSegmenterConstantBatch(
- std::function<ArgShape(size_t i)> shape_func,
+ const std::shared_ptr<DataType>& type,
+ std::function<ArgShape(int64_t key)> shape_func,
+ std::function<Result<std::shared_ptr<Scalar>>(int64_t key)> value_func,
std::function<Result<std::unique_ptr<RowSegmenter>>(const std::vector<TypeHolder>&)>
make_segmenter) {
- constexpr size_t n = 3, repetitions = 3;
- std::vector<TypeHolder> types = {int32(), int32(), int32()};
- std::vector<ArgShape> shapes(n);
- for (size_t i = 0; i < n; i++) shapes[i] = shape_func(i);
- auto full_batch = ExecBatchFromJSON(types, shapes, "[[1, 1, 1], [1, 1, 1], [1, 1, 1]]");
- auto test_by_size = [&](size_t size) -> Status {
- SCOPED_TRACE("constant-batch with " + ToChars(size) + " key(s)");
- std::vector<Datum> values(full_batch.values.begin(),
- full_batch.values.begin() + size);
- ExecBatch batch(values, full_batch.length);
- std::vector<TypeHolder> key_types(types.begin(), types.begin() + size);
+ constexpr int64_t n_keys = 3, n_rows = 3, repetitions = 3;
+ std::vector<TypeHolder> types(n_keys, type);
+ std::vector<Datum> full_values(n_keys);
+ for (int64_t i = 0; i < n_keys; i++) {
+ auto shape = shape_func(i);
+ ASSERT_OK_AND_ASSIGN(auto scalar, value_func(i));
+ if (shape == ArgShape::SCALAR) {
+ full_values[i] = std::move(scalar);
+ } else {
+ ASSERT_OK_AND_ASSIGN(full_values[i], MakeArrayFromScalar(*scalar, n_rows));
+ }
+ }
+ auto test_with_keys = [&](int64_t keys) -> Status {
+ SCOPED_TRACE("constant-batch with " + ToChars(keys) + " key(s)");
+ std::vector<Datum> values(full_values.begin(), full_values.begin() + keys);
+ ExecBatch batch(values, n_rows);
+ std::vector<TypeHolder> key_types(types.begin(), types.begin() + keys);
ARROW_ASSIGN_OR_RAISE(auto segmenter, make_segmenter(key_types));
- for (size_t i = 0; i < repetitions; i++) {
- TestSegments(segmenter, ExecSpan(batch), {{0, 3, true, true}});
+ for (int64_t i = 0; i < repetitions; i++) {
+ TestSegments(segmenter, ExecSpan(batch), {{0, n_rows, true, true}});
ARROW_RETURN_NOT_OK(segmenter->Reset());
}
return Status::OK();
};
- for (size_t i = 0; i <= 3; i++) {
- ASSERT_OK(test_by_size(i));
+ for (int64_t i = 0; i <= n_keys; i++) {
+ ASSERT_OK(test_with_keys(i));
}
}
} // namespace
TEST(RowSegmenter, ConstantArrayBatch) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::ARRAY; },
- MakeRowSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantScalarBatch) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::SCALAR; },
- MakeRowSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::SCALAR; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantMixedBatch) {
TestRowSegmenterConstantBatch(
- [](size_t i) { return i % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
- MakeRowSegmenter);
+ int32(),
+ [](int64_t key) { return key % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeRowSegmenter);
}
TEST(RowSegmenter, ConstantArrayBatchWithAnyKeysSegmenter) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::ARRAY; },
- MakeGenericSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
}
TEST(RowSegmenter, ConstantScalarBatchWithAnyKeysSegmenter) {
- TestRowSegmenterConstantBatch([](size_t i) { return ArgShape::SCALAR; },
- MakeGenericSegmenter);
+ TestRowSegmenterConstantBatch(
+ int32(), [](int64_t key) { return ArgShape::SCALAR; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
}
TEST(RowSegmenter, ConstantMixedBatchWithAnyKeysSegmenter) {
TestRowSegmenterConstantBatch(
- [](size_t i) { return i % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
- MakeGenericSegmenter);
+ int32(),
+ [](int64_t key) { return key % 2 == 0 ? ArgShape::SCALAR : ArgShape::ARRAY; },
+ [](int64_t key) { return MakeScalar(1); }, MakeGenericSegmenter);
+}
+
+TEST(RowSegmenter, ConstantFixedSizeBinaryArrayBatch) {
+ constexpr int fsb = 8;
+ auto type = fixed_size_binary(fsb);
+ ASSERT_OK_AND_ASSIGN(auto value, MakeScalar(type, std::string(fsb, 'X')));
+ TestRowSegmenterConstantBatch(
+ type, [](int64_t key) { return ArgShape::ARRAY; },
+ [&](int64_t key) { return value; }, MakeRowSegmenter);
Review Comment:
Well, `MakeGenericSegmenter` is relevant when there are nulls, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44166:
URL: https://github.com/apache/arrow/pull/44166#issuecomment-2359890848
:warning: GitHub issue #44167 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44167: [C++][Acero] Add more row segmenter tests [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #44166:
URL: https://github.com/apache/arrow/pull/44166#issuecomment-2359903163
Some new tests. @pitrou @mapleFU would you please take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org