You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2012/06/27 04:14:44 UTC
[jira] [Created] (HAMA-597) Split a GraphJobRunner into multiple
classes
Edward J. Yoon created HAMA-597:
-----------------------------------
Summary: Split a GraphJobRunner into multiple classes
Key: HAMA-597
URL: https://issues.apache.org/jira/browse/HAMA-597
Project: Hama
Issue Type: Improvement
Components: graph
Affects Versions: 0.5.0
Reporter: Edward J. Yoon
Assignee: Edward J. Yoon
Fix For: 0.6.0
Really not readable and maintainable.
Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452765#comment-13452765 ]
Thomas Jungblut commented on HAMA-597:
--------------------------------------
Do you think that this will lower the complexity? Personally we should extract a single superstep and refactor it into clean methods. Extracting a base class if we don't have multiple implementations is just confusing.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Mirko Kaempf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412766#comment-13412766 ]
Mirko Kaempf commented on HAMA-597:
-----------------------------------
I will look into this class to do some refactoring.
Are there some requirements to be aware of? If not I will just start to break it up into smaller peaces. I will compare it with the "GiraphRunner" to make both runner tools comparable in usage.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452856#comment-13452856 ]
Thomas Jungblut commented on HAMA-597:
--------------------------------------
I will have a look, most of the mess comes from me, so I should clean that up :/
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452959#comment-13452959 ]
Thomas Jungblut commented on HAMA-597:
--------------------------------------
Edward, can't we drastically simplify the loadVertices method?
What do you think about:
-Vertices are loaded from disk into RAM
-Multistep partitioning takes place (that can be combined with repair)
Imho this would be done in less than 100 lines.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Thomas Jungblut
> Fix For: 0.6.0
>
> Attachments: HAMA-597.patch
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452847#comment-13452847 ]
Edward J. Yoon commented on HAMA-597:
-------------------------------------
If GraphJobRunner can show clearly and concisely overall flow of program concisely (like main function in C/Java), I think moving all implementations into base class is also not bad idea. P.S., I'm not good Java programmer ;)
{quote}
We have lots of duplicate code.
{quote}
Agree.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-597:
--------------------------------
Assignee: (was: Edward J. Yoon)
Since I'm not good Java programmer, .. Someone can take this task? or comment your opinion?
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon reassigned HAMA-597:
-----------------------------------
Assignee: Mirko Kaempf
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Mirko Kaempf
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Jungblut updated HAMA-597:
---------------------------------
Attachment: HAMA-597.patch
Deleted the base again, added a aggregation runner.
Still the load vertices method needs to be cleansed. But what do you think about this refactoring? Is this more readable in your opinion?
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
> Attachments: HAMA-597.patch
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452836#comment-13452836 ]
Edward J. Yoon commented on HAMA-597:
-------------------------------------
{quote}Personally we should extract a single superstep and refactor it into clean methods.{quote}
Do you mean the logic in while loop?
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Mirko Kaempf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412798#comment-13412798 ]
Mirko Kaempf commented on HAMA-597:
-----------------------------------
To your question "But what is the reason to make it comparable to giraph?"
I started a review on availlable graph processing tools, so I found this:
(http://blog.acaro.org/entry/google-pregel-the-rise-of-the-clones)
"So, to summarize, what Hame, GoldenOrb and Giraph have in common is: Java platform, Apache License (and incubation), BSP computation. What they differ for: Hama offers BSP primitives not graph processing API (so it sits at a lower level)..."
In a separate project, it is called "hadoop distributed graph space" (HDGS) a Metadata store for graph processing (like Hive warehouse) and a generic workflow framework (compatible to Oozie) is under construction which is running on top of HDFS and HBase in a hadoop cluster.
I would like to see a common way to start these jobs based on HAMA and Giraph or simple MapReduce (for example for preprocessing graph data sets by analysing time series data in a comparable way, so it would be easy to have applications on a higher abstraction level which build workflows by combining different tasks using different computational concepts in one single Hadoop cluster.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Mirko Kaempf
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412812#comment-13412812 ]
Thomas Jungblut commented on HAMA-597:
--------------------------------------
There is the Job class concept which MapReduce already uses.
Hama has quite the same interfaces to submit the jobs like MapReduce has (job.submit, job.waitForCompletion). And as you may know, Giraph runs on top of MapReduce so basically it is the same.
What you are looking for is something that creates a common interface to start these jobs. That is not what the GraphJobRunner does, it is a bridge between the native BSP model and the higher level vertex abstraction in the Pregel paper.
The handling of job start and submission is handled by the GraphJob. And I do suggest you to not create a constant interface throughout various projects since there are too many options that diverge.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Mirko Kaempf
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412770#comment-13412770 ]
Thomas Jungblut commented on HAMA-597:
--------------------------------------
There are some intra-method dependencies, but since they work via the messaging API's you basically just have to take care on the sequence of calling them.
bq.I will compare it with the "GiraphRunner" to make both runner tools comparable in usage.
Well, have fun. But what is the reason to make it comparable to giraph?
If you have problems or questions, let us know.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Jungblut reassigned HAMA-597:
------------------------------------
Assignee: Thomas Jungblut (was: Edward J. Yoon)
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Thomas Jungblut
> Fix For: 0.6.0
>
> Attachments: HAMA-597.patch
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451778#comment-13451778 ]
Edward J. Yoon commented on HAMA-597:
-------------------------------------
Moved all except bsp(), setup(), and clean() to abstract class GraphJobRunnerBase.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452965#comment-13452965 ]
Thomas Jungblut commented on HAMA-597:
--------------------------------------
The multistep partitioning is a bit complex for me currently, I will read through it more carefully. Maybe we can't simplify it in less than 100 LOC.
Checked in the current version of refactoring now.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Thomas Jungblut
> Fix For: 0.6.0
>
> Attachments: HAMA-597.patch
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452925#comment-13452925 ]
Thomas Jungblut commented on HAMA-597:
--------------------------------------
Great, I will refactor the loadVertices method and then commit it.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
> Attachments: HAMA-597.patch
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon reassigned HAMA-597:
-----------------------------------
Assignee: Edward J. Yoon (was: Mirko Kaempf)
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453535#comment-13453535 ]
Hudson commented on HAMA-597:
-----------------------------
Integrated in Hama-Nightly #672 (See [https://builds.apache.org/job/Hama-Nightly/672/])
[HAMA-597]: Split a GraphJobRunner into multiple classes Part 1 (Revision 1383375)
Result = SUCCESS
tjungblut :
Files :
* /hama/trunk/CHANGES.txt
* /hama/trunk/graph/src/main/java/org/apache/hama/graph/AggregationRunner.java
* /hama/trunk/graph/src/main/java/org/apache/hama/graph/GraphJobMessage.java
* /hama/trunk/graph/src/main/java/org/apache/hama/graph/GraphJobRunner.java
* /hama/trunk/graph/src/main/java/org/apache/hama/graph/GraphJobRunnerBase.java
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Thomas Jungblut
> Fix For: 0.6.0
>
> Attachments: HAMA-597.patch
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Mirko Kaempf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412822#comment-13412822 ]
Mirko Kaempf commented on HAMA-597:
-----------------------------------
OK, thank you for the comment. As the GraphJob is already there, this item is clear to me now. And I will just make the code of GraphJobRunner more readable.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Mirko Kaempf
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452916#comment-13452916 ]
Edward J. Yoon commented on HAMA-597:
-------------------------------------
Thanks very nice!
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
> Attachments: HAMA-597.patch
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HAMA-597) Split a GraphJobRunner into multiple
classes
Posted by "Thomas Jungblut (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452841#comment-13452841 ]
Thomas Jungblut commented on HAMA-597:
--------------------------------------
Yes, also in the loadVertices method and others. We have lots of duplicate code.
> Split a GraphJobRunner into multiple classes
> --------------------------------------------
>
> Key: HAMA-597
> URL: https://issues.apache.org/jira/browse/HAMA-597
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.5.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Fix For: 0.6.0
>
>
> Really not readable and maintainable.
> Break up pieces of functionality into their own classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira