You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/04/08 08:00:42 UTC

[GitHub] [zookeeper] ztzg opened a new pull request #1677: ZOOKEEPER-4265: Fix broken download links (some files have been archived)

ztzg opened a new pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677


   The 3.5.9 release is not very old, but it "disappeared" from download mirrors when I updated the `zookeeper_dist` repository for 3.7.0.  The same thing happened to 3.6.1 a while ago.
   
   This commit removes 3.6.1 from the releases page, as 3.6.2 is a straightforward upgrade.
   
   It changes the 3.5.9 entries to point to the archive, as that release has not been declared EOL at this point.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] ztzg commented on a change in pull request #1677: ZOOKEEPER-4265: Fix broken download links (some files have been archived)

Posted by GitBox <gi...@apache.org>.
ztzg commented on a change in pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#discussion_r609650060



##########
File path: src/main/resources/markdown/releases.md
##########
@@ -42,18 +42,15 @@ Older releases are available.
 
 [Apache ZooKeeper 3.6.2 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.sha512))
 
-### Apache ZooKeeper 3.6.1
-
-[Apache ZooKeeper 3.6.1](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.sha512))
-
-[Apache ZooKeeper 3.6.1 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.sha512))
+### Apache ZooKeeper 3.5.9
 
+ZooKeeper 3.5.9 is only downloadable from the archive as the 3.6 and 3.7 branches are now `stable` and `current`, respectively.

Review comment:
       Well, I removed 3.5.9 from the "dist" (as per the instructions, not because I have something against it :) when I prepared 3.7.0.  I guess I should restore it in SVN, which will in turn cause it to be mirrored again?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] eolivelli commented on a change in pull request #1677: ZOOKEEPER-4265: Fix broken download links (some files have been archived)

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#discussion_r609636457



##########
File path: src/main/resources/markdown/releases.md
##########
@@ -42,18 +42,15 @@ Older releases are available.
 
 [Apache ZooKeeper 3.6.2 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.sha512))
 
-### Apache ZooKeeper 3.6.1
-
-[Apache ZooKeeper 3.6.1](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.sha512))
-
-[Apache ZooKeeper 3.6.1 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.sha512))
+### Apache ZooKeeper 3.5.9
 
+ZooKeeper 3.5.9 is only downloadable from the archive as the 3.6 and 3.7 branches are now `stable` and `current`, respectively.

Review comment:
       I am not sure we should delete 3.5.9 from the "dist", it is an active release line.
   if we want to change this fact we should open a discussion on dev@
   
   Good catch and good points @ztzg @arshadmohammad 

##########
File path: src/main/resources/markdown/releases.md
##########
@@ -42,18 +42,15 @@ Older releases are available.
 
 [Apache ZooKeeper 3.6.2 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.sha512))
 
-### Apache ZooKeeper 3.6.1
-
-[Apache ZooKeeper 3.6.1](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.sha512))
-
-[Apache ZooKeeper 3.6.1 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.sha512))
+### Apache ZooKeeper 3.5.9
 
+ZooKeeper 3.5.9 is only downloadable from the archive as the 3.6 and 3.7 branches are now `stable` and `current`, respectively.

Review comment:
       We have currently 3 active branches/release lines:
   - 3.5
   - 3.6
   - 3.7
   
   I am not sure we should say much here.
   
   we just have to give the links to binary/sources for the latest release of 3.5,3.6 and 3.7, so 3.5.9, 3.6.2, 3.7.0
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] ztzg commented on pull request #1677: ZOOKEEPER-4265: Fix broken download links (some files have been archived)

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#issuecomment-815547121


   @nkalmar, @eolivelli: I am of course not against restoring 3.5.9 in `zookeeper_dist` if you think it makes more sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] ztzg commented on pull request #1677: ZOOKEEPER-4265: Fix broken download links (some files have been archived)

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#issuecomment-815545686


   Cc: @arshadmohammad, as you will probably be the next person to update that page :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] sebbASF commented on pull request #1677: ZOOKEEPER-4265: Fix broken download links (some files have been archived)

Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#issuecomment-815673298


   It looks like the 3.6 and 3.7 branches are both currently being developed.
   
   If so, the latest version of each should be on the mirrors, and should be above the line separating them from older releases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1677: ZOOKEEPER-4265: Fix broken download links (some files have been archived)

Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on a change in pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#discussion_r609541741



##########
File path: src/main/resources/markdown/releases.md
##########
@@ -42,18 +42,15 @@ Older releases are available.
 
 [Apache ZooKeeper 3.6.2 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.sha512))
 
-### Apache ZooKeeper 3.6.1
-
-[Apache ZooKeeper 3.6.1](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.sha512))
-
-[Apache ZooKeeper 3.6.1 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.sha512))
+### Apache ZooKeeper 3.5.9
 
+ZooKeeper 3.5.9 is only downloadable from the archive as the 3.6 and 3.7 branches are now `stable` and `current`, respectively.

Review comment:
       >> the 3.6 and 3.7 branches are now `stable` and `current`, respectively.
   
   This is correct.
   
   But in the starting of this file it is written that "Apache ZooKeeper 3.7.0 is our latest stable release". is this statement just a carry forward from previous release or there is some thought behind declaring 3.7.0 as stable release
   
   do you think "Apache ZooKeeper 3.7.0 is our latest stable release" should be changed to "Apache ZooKeeper 3.7.0 is our current release" and later based on usage and feedback of 3.7.0 we can change 3.7.x as stable release.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] ztzg commented on pull request #1677: ZOOKEEPER-4265: Fix broken links (some files have been archived) & terminology

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#issuecomment-817179827


   Thanks; now merged in branch `website`; `asf-site` regenerated & pushed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1677: ZOOKEEPER-4265: Fix broken download links (some files have been archived)

Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on a change in pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#discussion_r609541741



##########
File path: src/main/resources/markdown/releases.md
##########
@@ -42,18 +42,15 @@ Older releases are available.
 
 [Apache ZooKeeper 3.6.2 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.sha512))
 
-### Apache ZooKeeper 3.6.1
-
-[Apache ZooKeeper 3.6.1](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.sha512))
-
-[Apache ZooKeeper 3.6.1 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.sha512))
+### Apache ZooKeeper 3.5.9
 
+ZooKeeper 3.5.9 is only downloadable from the archive as the 3.6 and 3.7 branches are now `stable` and `current`, respectively.

Review comment:
       >> the 3.6 and 3.7 branches are now `stable` and `current`, respectively.
   
   This is correct.
   
   But in the starting of this file it is written that "Apache ZooKeeper 3.7.0 is our latest stable release". is this statement just a carry forward from previous release or there is some thought behind declaring 3.7.0 as stable release
   
   I think "Apache ZooKeeper 3.7.0 is our latest stable release" to be changed to "Apache ZooKeeper 3.7.0 is our current release" and later based on usage and feedback of 3.7.0 we can change 3.7.x as stable release.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] ztzg closed pull request #1677: ZOOKEEPER-4265: Fix broken links (some files have been archived) & terminology

Posted by GitBox <gi...@apache.org>.
ztzg closed pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] ztzg commented on pull request #1677: ZOOKEEPER-4265: Fix broken links (some files have been archived) & terminology

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#issuecomment-817104364


   @arshadmohammad, @eolivelli, @sebbASF: PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] ztzg commented on pull request #1677: ZOOKEEPER-4265: Fix broken download links (some files have been archived)

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#issuecomment-815727475


   > It looks like the 3.6 and 3.7 branches are both currently being developed.
   
   Indeed.
   
   > If so, the latest version of each should be on the mirrors
   
   Right.  (And that is indeed the case, unless I missed something.)
   
   > and should be above the line separating them from older releases.
   
   Good point; I have moved 3.6.2 back "above the fold."


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] ztzg commented on a change in pull request #1677: ZOOKEEPER-4265: Fix broken download links (some files have been archived)

Posted by GitBox <gi...@apache.org>.
ztzg commented on a change in pull request #1677:
URL: https://github.com/apache/zookeeper/pull/1677#discussion_r609618882



##########
File path: src/main/resources/markdown/releases.md
##########
@@ -42,18 +42,15 @@ Older releases are available.
 
 [Apache ZooKeeper 3.6.2 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2.tar.gz.sha512))
 
-### Apache ZooKeeper 3.6.1
-
-[Apache ZooKeeper 3.6.1](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz.sha512))
-
-[Apache ZooKeeper 3.6.1 Source Release](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz)([asc](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.asc), [sha512](https://downloads.apache.org/zookeeper/zookeeper-3.6.1/apache-zookeeper-3.6.1.tar.gz.sha512))
+### Apache ZooKeeper 3.5.9
 
+ZooKeeper 3.5.9 is only downloadable from the archive as the 3.6 and 3.7 branches are now `stable` and `current`, respectively.

Review comment:
       Good point.  That sentence was just carried forward when I switched the versions in the release notes, and I certainly agree that it is a bit early to declare 3.7 stable compared to 3.6.  How about the updated patch?  (It implements your suggestion, but I have also moved 3.6 above the separator line.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org