You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/10/06 00:55:22 UTC

[jclouds] Reactivate Checkstyle in the jclouds build (#551)

See https://issues.apache.org/jira/browse/JCLOUDS-736. This _should_ work (looks OK locally), but not sure about how jclouds-resources will handle the dependency...
You can merge this Pull Request by running:

  git pull https://github.com/jclouds/jclouds reactivate-checkstyle

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/551

-- Commit Summary --

  * Overriding modernizer-plugin config in jclouds-resources
  * Moving checkstyle-plugin config to profiles
  * Overriding checkstyle-plugin config in jclouds-resources

-- File Changes --

    M project/pom.xml (13)
    M resources/pom.xml (24)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/551.patch
https://github.com/jclouds/jclouds/pull/551.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
> Now to try `help:effective-pom clean install checkstyle:checkstyle -e -pl core`

OK, that worked. Now to try with resources _and_ core. I have a suspicion Maven's replacement of external deps with references to target directories in the same reactor may be causing the problem here...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58125237

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1737](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1737/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58112878

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
> jclouds-pull-requests #1233 UNSTABLE

One of our [spurious test failures](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-compute/1233/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/). Still some Checkstyle issues, though...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-57969433

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
Closed #551.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#event-174793729

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #153](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/153/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58038509

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Adrian Cole <no...@github.com>.
if you don't mind, I'd rather let #555 finish and merge that first. It takes ages to have pull requests rechecked, and another checkstyle-based rebase is just salt on the wound.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58072347

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
Bouncing to run the PR builders on the updated commits

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58097147

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #157](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/157/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58093425

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
> jclouds-pull-requests #1242 UNSTABLE

One of our spurious [test failures](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-compute/1242/testReport/junit/org.jclouds.compute.callables/BlockUntilInitScriptStatusIsZeroThenReturnOutputTest/testloopUntilTrueOrThrowCancellationExceptionReturnsWhenPredicateIsTrueSecondTimeWhileNotCancelled/)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58049200

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1233](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1233/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-57957356

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #158](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/158/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58097459

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #155](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/155/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58051311

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Adrian Cole <no...@github.com>.
Reopened #551.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#event-174773784

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1728](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1728/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58042018

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
Bouncing to trigger DEV@cloud...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58038236

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
> Trying to reproduce locally

OK, can't reproduce locally: `mvn clean verify checkstyle:checkstyle` is fine. Will now try in DEV@cloud:

https://jclouds.ci.cloudbees.com/job/DEBUG-jclouds-checkstyle/

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58114882

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Adrian Cole <no...@github.com>.
oops sorry!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58090748

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
Hmpf. Barfing in DEV@clouds too now. First with a weird JVM crash and, after removing `checkstyle:checkstyle`, with a dependency error in jclouds-core:

* https://jclouds.ci.cloudbees.com/job/jclouds/2799/console
* https://jclouds.ci.cloudbees.com/job/jclouds/2801/console

Trying to reproduce locally. Will revert that commit again if this isn't fixed.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58114409

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
> Now for a [final run of the entire project](https://jclouds.ci.cloudbees.com/job/DEBUG-jclouds-checkstyle-verify-phase/6/console)...

```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache jclouds Project ............................ SUCCESS [1:15.989s]
[INFO] jclouds shared Maven resources .................... SUCCESS [21.572s]
[INFO] jclouds Components Core ........................... SUCCESS [2:08.564s]
[INFO] jclouds OpenStack Components Core ................. SUCCESS [13.871s]
[INFO] jclouds commons project ........................... SUCCESS [3.025s]
[INFO] jclouds script builder ............................ SUCCESS [18.828s]
[INFO] jclouds compute core .............................. SUCCESS [42.833s]
[INFO] jclouds Log4J Logging Module ...................... SUCCESS [6.041s]
[INFO] jclouds loadbalancer core ......................... SUCCESS [17.740s]
[INFO] jclouds sts api ................................... SUCCESS [10.594s]
[INFO] jclouds cloudwatch api ............................ SUCCESS [10.696s]
[INFO] jclouds SLF4J Logging Module ...................... SUCCESS [12.224s]
[INFO] jclouds bouncycastle EncryptionService Module ..... SUCCESS [4.846s]
[INFO] jclouds sshj ssh client ........................... SUCCESS [9.879s]
[INFO] jclouds cloudstack core ........................... SUCCESS [57.416s]
[INFO] jclouds blobstore core ............................ SUCCESS [16.593s]
[INFO] jclouds filesystem core ........................... SUCCESS [5.618s]
[INFO] jclouds bring your own node provider .............. SUCCESS [8.910s]
[INFO] jclouds OkHttp Driver ............................. SUCCESS [7.213s]
[INFO] jclouds s3 api .................................... SUCCESS [14.674s]
[INFO] jclouds ec2 api ................................... SUCCESS [26.654s]
[INFO] jclouds sqs api ................................... SUCCESS [10.277s]
[INFO] jclouds vcloud api ................................ SUCCESS [22.933s]
[INFO] jclouds elasticstack core ......................... SUCCESS [14.290s]
[INFO] jclouds atmos components .......................... SUCCESS [19.871s]
[INFO] jclouds openstack-keystone api .................... SUCCESS [13.063s]
[INFO] jclouds swift api ................................. SUCCESS [11.638s]
[INFO] jclouds openstack-cinder api ...................... SUCCESS [5.687s]
[INFO] Apache jclouds :: OpenStack :: Nova API ........... SUCCESS [27.332s]
[INFO] jclouds openstack-nova-ec2 api .................... SUCCESS [6.383s]
[INFO] jclouds openstack-trove api ....................... SUCCESS [10.244s]
[INFO] jclouds cloudfiles api ............................ SUCCESS [9.601s]
[INFO] jclouds cloudservers api .......................... SUCCESS [12.230s]
[INFO] jclouds rackspace cloudidentity api ............... SUCCESS [5.306s]
[INFO] jclouds Rackspace Cloud Load Balancers API ........ SUCCESS [18.736s]
[INFO] jclouds Rackspace Next Generation Cloud Servers US provider  SUCCESS [4.783s]
[INFO] jclouds rackspace clouddns api .................... SUCCESS [10.660s]
[INFO] jclouds route53 api ............................... SUCCESS [14.071s]
[INFO] jclouds apis project .............................. SUCCESS [3.068s]
[INFO] jclouds GoGrid provider ........................... SUCCESS [11.873s]
[INFO] jclouds Azure Storage provider .................... SUCCESS [9.582s]
[INFO] jclouds Apache Http Components Client ............. SUCCESS [7.940s]
[INFO] jclouds joda DateService Module ................... SUCCESS [3.696s]
[INFO] jclouds netty payload module ...................... SUCCESS [4.293s]
[INFO] jclouds enterprise Module ......................... SUCCESS [3.806s]
[INFO] jclouds Amazon Simple Storage Service (S3) provider  SUCCESS [10.113s]
[INFO] jclouds Amazon Elastic Load Balancer provider ..... SUCCESS [4.305s]
[INFO] jclouds Amazon EC2 provider ....................... SUCCESS [15.693s]
[INFO] jclouds Amazon Simple Queue Service provider ...... SUCCESS [4.156s]
[INFO] jclouds ElasticHosts Peer1 London provider ........ SUCCESS [5.259s]
[INFO] jclouds ElasticHosts Peer1 San Antonio provider ... SUCCESS [3.866s]
[INFO] jclouds ElasticHosts BlueSquare London provider ... SUCCESS [4.091s]
[INFO] jclouds ElasticHosts Peer1 Toronto provider ....... SUCCESS [4.152s]
[INFO] jclouds ElasticHosts Peer1 Los Angeles provider ... SUCCESS [5.425s]
[INFO] jclouds ElasticHosts Amsterdam provider ........... SUCCESS [4.003s]
[INFO] jclouds ElasticHosts San Jose provider ............ SUCCESS [3.918s]
[INFO] jclouds ElasticHosts Hong Kong provider ........... SUCCESS [3.932s]
[INFO] jclouds ElasticHosts Sydney provider .............. SUCCESS [4.049s]
[INFO] jclouds Open Hosting East1 provider ............... SUCCESS [4.341s]
[INFO] jclouds Serverlove Manchester provider ............ SUCCESS [3.961s]
[INFO] jclouds SkaliCloud Malaysia provider .............. SUCCESS [5.842s]
[INFO] jclouds Go2Cloud Johannesburg1 provider ........... SUCCESS [4.529s]
[INFO] jclouds SoftLayer core ............................ SUCCESS [11.108s]
[INFO] jclouds HP Cloud Compute provider ................. SUCCESS [4.426s]
[INFO] jclouds HP Cloud Block Storage Provider ........... SUCCESS [4.250s]
[INFO] jclouds HP Cloud Object Storage ................... SUCCESS [6.371s]
[INFO] jclouds CloudServers US provider .................. SUCCESS [4.220s]
[INFO] jclouds CloudServers UK provider .................. SUCCESS [4.144s]
[INFO] jclouds CloudFiles US provider .................... SUCCESS [4.216s]
[INFO] jclouds CloudFiles UK provider .................... SUCCESS [3.640s]
[INFO] jclouds Rackspace Next Generation Cloud DNS US provider  SUCCESS [3.717s]
[INFO] jclouds Rackspace Next Generation Cloud DNS UK provider  SUCCESS [3.589s]
[INFO] jclouds Rackspace Cloud Databases US provider ..... SUCCESS [7.451s]
[INFO] jclouds Rackspace Cloud Databases UK provider ..... SUCCESS [4.698s]
[INFO] jclouds Rackspace Cloud Load Balancers US provider  SUCCESS [4.095s]
[INFO] jclouds Rackspace Cloud Load Balancers UK provider  SUCCESS [4.529s]
[INFO] jclouds Rackspace Next Generation Cloud Servers provider  SUCCESS [5.329s]
[INFO] jclouds Rackspace Next Generation Cloud Block Storage US provider  SUCCESS [4.117s]
[INFO] jclouds Rackspace Next Generation Cloud Block Storage UK provider  SUCCESS [4.232s]
[INFO] jclouds GleSYS core ............................... SUCCESS [11.051s]
[INFO] jclouds Amazon Identity and Access Management (STS) provider  SUCCESS [3.637s]
[INFO] jclouds Amazon Route 53 provider .................. SUCCESS [3.657s]
[INFO] jclouds ultradns-ws provider ...................... SUCCESS [10.380s]
[INFO] jclouds dynect api ................................ SUCCESS [8.679s]
[INFO] jclouds providers project ......................... SUCCESS [2.928s]
[INFO] jclouds jsch ssh client ........................... SUCCESS [5.483s]
[INFO] jclouds example components for a standalone compute provider  SUCCESS [5.312s]
[INFO] jclouds skeletons project ......................... SUCCESS [3.219s]
[INFO] jclouds Google App Engine Components .............. SUCCESS [12.103s]
[INFO] jclouds drivers project ........................... SUCCESS [2.194s]
[INFO] allcompute ........................................ SUCCESS [7.297s]
[INFO] allblobstore ...................................... SUCCESS [4.878s]
[INFO] allloadbalancer ................................... SUCCESS [3.679s]
[INFO] all ............................................... SUCCESS [5.888s]
[INFO] Apache jclouds .................................... SUCCESS [5.367s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:16.178s
[INFO] Finished at: Tue Oct 07 00:43:02 EDT 2014
[INFO] Final Memory: 163M/365M
[INFO] ------------------------------------------------------------------------
```
OK! Merged to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=e6bf0cc9af726dcbebf4515ae49398ebfd1f8353)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58135763

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
Weird. Works with `validate -pl resources,core` and with `checkstyle:checkstyle -pl resources,core`. Now trying the next combo.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58128079

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
It gets even better: `clean install` indeed fails but `clean verify` works. **sigh**

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58132185

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1247](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1247/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58108354

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
> jclouds-pull-requests #1246 ABORTED

I killed this one as we had two PR builders running.

> jclouds » jclouds #1734 UNSTABLE

[Flaky test](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds$jclouds-compute/1734/testReport/org.jclouds.compute.callables/BlockUntilInitScriptStatusIsZeroThenReturnOutputTest/testloopUntilTrueOrThrowCancellationExceptionReturnsWhenPredicateIsTrueSecondTimeWhileNotCancelled/) unrelated to this PR

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58100169

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
>  I'd rather let #555 finish and merge that first.

Fine with me. Let's get that in, then we can run this again if necessary.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58072486

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
Hm. `help:effective-pom clean install -X -e -rf core` [seems to get past the Checkstyle bit](https://jclouds.ci.cloudbees.com/job/DEBUG-jclouds-checkstyle/2/console) in DEV@cloud. Now to try `mvn clean install checkstyle:checkstyle -e -pl core`

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58116641

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1244](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1244/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58063750

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
It **is** barfing reproducibly in DEV@cloud, at least.

@adriancole @ccustine @everett-toews Could any of you just try `mvn clean verify` or so on an up-to-date local repo to see if you get this too? Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58115950

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1732](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1732/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58078588

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Adrian Cole <no...@github.com>.
cherry-picked into master, 1.8.x I will raise subsequent PRs to adjust jclouds-chef, labs-* repos.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58088872

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1718](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1718/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-57974514

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1738](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1738/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58118434

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
> cherry-picked into master, 1.8.x I will raise subsequent PRs to adjust jclouds-chef, labs-* repos.

Did you mean a different PR here..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58090327

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
@adriancole Still good to go for you?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58064828

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
OK, seems to be clear now: `install` doesn't play nicely (even locally) with the Checkstyle plugin if the latter is bound to the `validate` phase.

Trying `clean install checkstyle:checkstyle -e -pl resources,core` with a branch that moves the invocation back to the default `verify` phase:

https://jclouds.ci.cloudbees.com/job/DEBUG-jclouds-checkstyle-verify-phase/5/

(can't use the PR builder for this as that only runs `verify`...)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58133973

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
Ha! So `install checkstyle:checkstyle -X -e -pl resources,core` succeeds but `clean install checkstyle:checkstyle -X -e -pl resources,core` fails!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58129466

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
> jclouds » jclouds #1737 FAILURE

Some odd merge error? Will wait to see if trunk is actually broken.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58113362

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Adrian Cole <no...@github.com>.
flakey test + checkstyle which is fixed in #555

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58049267

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1734](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1734/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58099951

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1242](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1242/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58048649

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
> https://jclouds.ci.cloudbees.com/job/DEBUG-jclouds-checkstyle-verify-phase/5/

Yay!
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] jclouds shared Maven resources .................... SUCCESS [58.198s]
[INFO] jclouds Components Core ........................... SUCCESS [4:13.308s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:21.369s
[INFO] Finished at: Tue Oct 07 00:18:15 EDT 2014
[INFO] Final Memory: 60M/176M
[INFO] ------------------------------------------------------------------------
```
Now for a final run of the entire project...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58134412

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
> Now trying the next combo.

`install -X -e -pl resources,core` works too. `install checkstyle:checkstyle -X -e -pl resources,core` next.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58128511

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=b0f2962c22c471ee34c1960a58b63f66f8bbe4b0)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-58108744

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by Andrew Phillips <no...@github.com>.
Closed #551.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#event-174835267

Re: [jclouds] Reactivate Checkstyle in the jclouds build (#551)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #144](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/144/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/551#issuecomment-57955752