You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "slievrly (via GitHub)" <gi...@apache.org> on 2026/10/04 16:20:30 UTC
[PR] ci: upload JDK 17 coverage with Redis and Nacos tests [incubator-seata]
slievrly opened a new pull request, #8297:
URL: https://github.com/apache/incubator-seata/pull/8297
- [x] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
Upload Codecov coverage from the JDK 17 job so the report includes the Server module, which is activated on JDK 17+. Keep the existing JDK 8/17/21/25 test matrix.
Add a dedicated JDK 17 test step with `redisCaseEnabled=true` and `nacosCaseEnabled=true`, using the existing Redis/Nacos services. Generate the final JaCoCo report after all test executions, including the separate Server Raft execution. JDK 8 retains its license check and Redis/Nacos tests; JDK 21/25 retain their existing test commands.
### Ⅱ. Does this pull request fix one issue?
No linked issue.
### Ⅲ. Why don't you add test cases (unit test/integration test)?
This change adjusts CI test execution and coverage upload selection, without changing application code.
### Ⅳ. Describe how to verify it
Local checks passed:
- YAML parsing and shell syntax checks for the Maven test commands.
- All four JDK matrix values select exactly one test step.
- Redis/Nacos tests are enabled for JDK 8 and 17, and only JDK 17 uploads to Codecov.
- `git diff --check`.
The full matrix, service-backed tests and Codecov upload must be verified by GitHub Actions; they were not rerun locally.
### Ⅴ. Special notes for reviews
The coverage baseline will change because the uploaded report now includes JDK 17 modules. Console/Namingserver, activated on JDK 25, are still outside the main uploaded report. Coverage exclusions and Codecov thresholds are unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] ci: centralize JDK test configuration and upload JDK 25 coverage [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #8297:
URL: https://github.com/apache/incubator-seata/pull/8297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] ci: upload JDK 17 coverage with Redis and Nacos tests [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8297:
URL: https://github.com/apache/incubator-seata/pull/8297#issuecomment-5982203052
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/8297?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.19%. Comparing base ([`d38c41f`](https://app.codecov.io/gh/apache/incubator-seata/commit/d38c41f35553e7f0650bde80242f7aad41c4850d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`44ba342`](https://app.codecov.io/gh/apache/incubator-seata/commit/44ba342cb9f6e118b3a848941853c1c1dee0e62e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #8297 +/- ##
============================================
+ Coverage 73.91% 76.19% +2.27%
+ Complexity 1146 907 -239
============================================
Files 1156 1333 +177
Lines 42396 51127 +8731
Branches 5067 6137 +1070
============================================
+ Hits 31338 38954 +7616
- Misses 8576 9240 +664
- Partials 2482 2933 +451
```
[see 303 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/8297/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/8297?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org