You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "jojochuang (via GitHub)" <gi...@apache.org> on 2024/08/26 21:57:30 UTC
[PR] HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose [ozone]
jojochuang opened a new pull request, #7121:
URL: https://github.com/apache/ozone/pull/7121
## What changes were proposed in this pull request?
HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose
Please describe your PR in detail:
1. Removed \@Flaky annotation from TestBlockOutputStreamWithFailures#testContainerClose and TestBlockOutputStream#testWriteMoreThanMaxFlushSize
2. Relaxed the assertions in the test to match the current behavior.
3. Verified there's no longer intermittent test failures in TestBlockOutputStreamWithFailures#testContainerClose and TestBlockOutputStream#testWriteMoreThanMaxFlushSize
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11325
## How was this patch tested?
Flaky-test-check:
https://github.com/jojochuang/ozone/actions/runs/10532241331
TestBlockOutputStream#testWriteMoreThanMaxFlushSize[HDDS-11325-take2]-10x10
https://github.com/jojochuang/ozone/actions/runs/10565349000
TestBlockOutputStreamWithFailures#testContainerClose[HDDS-11325-take2]-10x10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7121:
URL: https://github.com/apache/ozone/pull/7121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7121:
URL: https://github.com/apache/ozone/pull/7121#discussion_r1734267966
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStream.java:
##########
@@ -662,7 +661,6 @@ void testWriteExactlyMaxFlushSize(boolean flushDelay, boolean enablePiggybacking
@ParameterizedTest
@MethodSource("clientParameters")
- @Flaky("HDDS-11325")
Review Comment:
Got it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #7121:
URL: https://github.com/apache/ozone/pull/7121#discussion_r1733466782
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStream.java:
##########
@@ -662,7 +661,6 @@ void testWriteExactlyMaxFlushSize(boolean flushDelay, boolean enablePiggybacking
@ParameterizedTest
@MethodSource("clientParameters")
- @Flaky("HDDS-11325")
Review Comment:
Yes....it was fixed in a prior commit https://github.com/apache/ozone/commit/2d3ba800ead113b2c789d3643f96abec6ad57b7d
sorry it was confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7121:
URL: https://github.com/apache/ozone/pull/7121#issuecomment-2314973466
Thanks @jojochuang for the patch, @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #7121:
URL: https://github.com/apache/ozone/pull/7121#issuecomment-2311349250
It failed in CI at a later location. This one might indicate product issue actually.
```
Error: Tests run: 24, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 29.049 s <<< FAILURE! - in org.apache.hadoop.ozone.client.rpc.TestBlockOutputStream
Error: org.apache.hadoop.ozone.client.rpc.TestBlockOutputStream.testWriteMoreThanFlushSize(boolean, boolean)[3] Time elapsed: 0.053 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <250> but was: <50>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:166)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:161)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:632)
at org.apache.hadoop.ozone.client.rpc.TestBlockOutputStream.testWriteMoreThanFlushSize(TestBlockOutputStream.java:539)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7121:
URL: https://github.com/apache/ozone/pull/7121#discussion_r1732267619
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStream.java:
##########
@@ -662,7 +661,6 @@ void testWriteExactlyMaxFlushSize(boolean flushDelay, boolean enablePiggybacking
@ParameterizedTest
@MethodSource("clientParameters")
- @Flaky("HDDS-11325")
Review Comment:
I don't think `@Flaky` should be removed without other code changes (test or production) that could fix the failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org