You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/09/21 23:17:02 UTC
Review Request 68806: Removed outdated comments for mocking the secret
generator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68806/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Removed an outdated comment for mocking the secret generator.
Diffs
-----
src/tests/cluster.cpp cb7d3f0298dfa8c11634d6674f93f2f355b48a53
src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
Diff: https://reviews.apache.org/r/68806/diff/1/
Testing
-------
N/A
Thanks,
Chun-Hung Hsiao
Re: Review Request 68806: Fixed outdated comments for mocking the
secret generator.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68806/#review210235
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Sept. 21, 2018, 4:17 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68806/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2018, 4:17 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed outdated comments for mocking the secret generator.
>
>
> Diffs
> -----
>
> src/tests/cluster.cpp cb7d3f0298dfa8c11634d6674f93f2f355b48a53
> src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
>
>
> Diff: https://reviews.apache.org/r/68806/diff/2/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68806: Fixed outdated comments for mocking the
secret generator.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68806/#review208914
-----------------------------------------------------------
PASS: Mesos patch 68806 was successfully built and tested.
Reviews applied: `['68806']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2378/mesos-review-68806
- Mesos Reviewbot Windows
On Sept. 21, 2018, 11:17 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68806/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2018, 11:17 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed outdated comments for mocking the secret generator.
>
>
> Diffs
> -----
>
> src/tests/cluster.cpp cb7d3f0298dfa8c11634d6674f93f2f355b48a53
> src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
>
>
> Diff: https://reviews.apache.org/r/68806/diff/2/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>