You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/26 11:24:05 UTC
[GitHub] [spark] roczei opened a new pull request, #37677: SPARK-40039: Fixes a scala style check issue
roczei opened a new pull request, #37677:
URL: https://github.com/apache/spark/pull/37677
### What changes were proposed in this pull request?
The dev/run-tests script indicated a scala style error because the line was too long. This change fixes this issue.
### Why are the changes needed?
Same as the previous reason.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
I have just validated again with the ./dev/run-tests script which started the scala style checks. Result:
```
========================================================================
Running Scala style checks
========================================================================
[info] Checking Scala style using SBT with these profiles: -Phadoop-3 -Pyarn -Pkubernetes -Phadoop-cloud -Pspark-ganglia-lgpl -Pdocker-integration-tests -Phive -Phive-thriftserver -Pmesos -Pkinesis-asl
Using SPARK_LOCAL_IP=127.0.0.1
Scalastyle checks passed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37677: [SPARK-40039][SS][FOLLOWUP] Fixes scala style check issue
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37677:
URL: https://github.com/apache/spark/pull/37677#issuecomment-1229123607
Reverted for now. See also https://github.com/apache/spark/pull/37474#issuecomment-1229123426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #37677: [SPARK-40039][SS][FOLLOWUP] Fixes scala style check issue
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #37677:
URL: https://github.com/apache/spark/pull/37677#issuecomment-1228527027
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #37677: SPARK-40039: Fixes a scala style check issue
Posted by GitBox <gi...@apache.org>.
attilapiros commented on PR #37677:
URL: https://github.com/apache/spark/pull/37677#issuecomment-1228405870
@roczei Thanks for fixing this! It is interesting how the checks were clean on my PR.
But now I have run Scala style check against all my files and there is one more:
```
[ERROR] /Users/attilazsoltpiros/git/attilapiros/spark-review/hadoop-cloud/src/test/java/org/apache/spark/internal/io/cloud/abortable/AbortableFileSystem.java:27:8: Unused import - org.apache.hadoop.fs.statistics.BufferedIOStatisticsOutputStream. [UnusedImports]
```
May I ask you to take care of that one here, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #37677: [SPARK-40039][SS][FOLLOWUP] Fixes scala style check issue
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #37677: [SPARK-40039][SS][FOLLOWUP] Fixes scala style check issue
URL: https://github.com/apache/spark/pull/37677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] roczei commented on pull request #37677: SPARK-40039: Fixes a scala style check issue
Posted by GitBox <gi...@apache.org>.
roczei commented on PR #37677:
URL: https://github.com/apache/spark/pull/37677#issuecomment-1228449009
> May I ask you to take care of this too within your PR?
@attilapiros Yes, I have deleted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org