You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by na...@apache.org on 2017/03/31 20:48:44 UTC

samza git commit: SAMZA-1182 - Commenting out some of the flaky tests

Repository: samza
Updated Branches:
  refs/heads/master 9db47b861 -> 944c70878


SAMZA-1182 - Commenting out some of the flaky tests

Author: navina <na...@apache.org>

Reviewers: Prateek Maheshwari <pm...@linkedin.com>, Jagadish Venkataraman <vj...@gmail.com>

Closes #107 from navina/SAMZA-1182


Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/944c7087
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/944c7087
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/944c7087

Branch: refs/heads/master
Commit: 944c70878797a316be0a5be4f4d3ad9238666f3c
Parents: 9db47b8
Author: Navina Ramesh <na...@apache.org>
Authored: Fri Mar 31 13:48:35 2017 -0700
Committer: nramesh <nr...@linkedin.com>
Committed: Fri Mar 31 13:48:35 2017 -0700

----------------------------------------------------------------------
 .../src/test/java/org/apache/samza/task/TestAsyncRunLoop.java  | 6 ++++--
 .../java/org/apache/samza/monitor/TestLocalStoreMonitor.java   | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/samza/blob/944c7087/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
----------------------------------------------------------------------
diff --git a/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java b/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
index 58412a7..adb399f 100644
--- a/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
+++ b/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
@@ -237,7 +237,8 @@ public class TestAsyncRunLoop {
     assertEquals(2L, containerMetrics.processes().getCount());
   }
 
-  @Test
+  // TODO: Fix in SAMZA-1183
+  //@Test
   public void testProcessInOrder() throws Exception {
     AsyncRunLoop runLoop = createRunLoop();
     when(consumerMultiplexer.choose(false)).thenReturn(envelope0).thenReturn(envelope3).thenReturn(envelope1).thenReturn(null);
@@ -519,7 +520,8 @@ public class TestAsyncRunLoop {
     callbackExecutor.awaitTermination(100, TimeUnit.MILLISECONDS);
   }
 
-  @Test
+  // TODO: Fix in SAMZA-1183
+  // @Test
   public void testCommitBehaviourWhenAsyncCommitIsEnabled() throws InterruptedException {
     commitRequest = TaskCoordinator.RequestScope.CURRENT_TASK;
     maxMessagesInFlight = 2;

http://git-wip-us.apache.org/repos/asf/samza/blob/944c7087/samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java
----------------------------------------------------------------------
diff --git a/samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java b/samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java
index bd666ad..02ec321 100644
--- a/samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java
+++ b/samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java
@@ -83,7 +83,8 @@ public class TestLocalStoreMonitor {
     FileUtils.deleteDirectory(taskStoreDir);
   }
 
-  @Test
+  // TODO: Fix in SAMZA-1183
+  //@Test
   public void shouldDeleteLocalTaskStoreWhenItHasNoOffsetFile() throws Exception {
     localStoreMonitor.monitor();
     assertTrue("Task store directory should not exist.", !taskStoreDir.exists());
@@ -132,7 +133,8 @@ public class TestLocalStoreMonitor {
     assertEquals(0, localStoreMonitorMetrics.diskSpaceFreedInBytes.getCount());
   }
 
-  @Test
+  // TODO: Fix in SAMZA-1183
+  //@Test
   public void shouldDeleteTaskStoreWhenTaskPreferredStoreIsNotLocalHost() throws Exception {
     Task task = new Task("notLocalHost", "test-task", 0,
                          new ArrayList<>(), ImmutableList.of("test-store"));