You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Guosmilesmile (via GitHub)" <gi...@apache.org> on 2026/07/24 09:07:27 UTC
[PR] Doc: Fix incorrect weight value description for range-distribution-sort-key-base-weight in Flink [iceberg]
Guosmilesmile opened a new pull request, #17351:
URL: https://github.com/apache/iceberg/pull/17351
The documented value `0.02` is inconsistent with the actual weighting logic in MapAssignment, where the value is divided by 100 (`closeFileCostWeightPercentage / 100`). `rangeDistributionSortKeyBaseWeight` will be directly assigned to `closeFileCostWeightPercentage`.
https://github.com/apache/iceberg/blob/8de28da314ec2f13251dac8b7dc0c7de1f899d2e/flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/MapAssignment.java#L129-133
To represent 2%, users should set `2.0`, not `0.02`. This fixes the incorrect weight value in the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Doc: Fix incorrect weight value description for range-distribution-sort-key-base-weight in Flink [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #17351:
URL: https://github.com/apache/iceberg/pull/17351#issuecomment-5070293078
Merged to main.
Thanks @Guosmilesmile for the fix and @uros-b for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Doc: Fix incorrect weight value description for range-distribution-sort-key-base-weight in Flink [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #17351:
URL: https://github.com/apache/iceberg/pull/17351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Doc: Fix incorrect weight value description for range-distribution-sort-key-base-weight in Flink [iceberg]
Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on PR #17351:
URL: https://github.com/apache/iceberg/pull/17351#issuecomment-5068415885
Add a update for all flink version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org