You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by "andrewmusselman (via GitHub)" <gi...@apache.org> on 2026/06/30 19:07:46 UTC
[PR] Add Downloads pass/fail column to site-scan overview [whimsy]
andrewmusselman opened a new pull request, #318:
URL: https://github.com/apache/whimsy/pull/318
The crawler already collects a 'downloads' map for each site, but it was never surfaced in the all-projects/all-podlings overview table.
Add a 'Downloads' column that flags whether any download links were found: sites with none are marked red (SITE_FAIL) like other failing checks, and sites with downloads are marked green (SITE_PASS) with the discovered URLs available in a hover tooltip. The column uses the same sort_order values as the existing check columns so it sorts pass/fail alongside them.
This is display-only; no changes to the crawler or SiteStandards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Downloads pass/fail column to site-scan overview [whimsy]
Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on code in PR #318:
URL: https://github.com/apache/whimsy/pull/318#discussion_r3510544352
##########
lib/whimsy/sitewebsite.rb:
##########
@@ -206,6 +210,17 @@ def display_overview(sites, analysis, checks, tlp = true)
cls = SiteStandards.label(analysis, links, c, n)
_td '', class: cls, data_sort_value: sort_order[cls]
end
+ downloads = links['downloads'] || {}
+ if downloads.empty?
Review Comment:
I re-purposed amber for the downloads column to mean "not expected," got nonpmc values from the committee, and hard-coded PMCs that don't have downloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Downloads pass/fail column to site-scan overview [whimsy]
Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on code in PR #318:
URL: https://github.com/apache/whimsy/pull/318#discussion_r3510439287
##########
lib/whimsy/sitewebsite.rb:
##########
@@ -206,6 +210,17 @@ def display_overview(sites, analysis, checks, tlp = true)
cls = SiteStandards.label(analysis, links, c, n)
_td '', class: cls, data_sort_value: sort_order[cls]
end
+ downloads = links['downloads'] || {}
+ if downloads.empty?
Review Comment:
Okay, for PMCs that don't make releases and other websites like Brand Management, Data Privacy, Diversity, (what else?) we add another color/legend to:
```
* Sites with links to primary ASF page
* Sites with link, but not an expected ASF one
* Sites with no link for this topic
```
E.g., "Sites with no link for this topic, and not expected to"
And hard code it or find that data?
I am red/green colorblind so please tell me what you would like in hex code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Downloads pass/fail column to site-scan overview [whimsy]
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on code in PR #318:
URL: https://github.com/apache/whimsy/pull/318#discussion_r3501552061
##########
lib/whimsy/sitewebsite.rb:
##########
@@ -206,6 +210,17 @@ def display_overview(sites, analysis, checks, tlp = true)
cls = SiteStandards.label(analysis, links, c, n)
_td '', class: cls, data_sort_value: sort_order[cls]
end
+ downloads = links['downloads'] || {}
+ if downloads.empty?
Review Comment:
Here is a list: attic, comdev, gump, and whimsy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Downloads pass/fail column to site-scan overview [whimsy]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on code in PR #318:
URL: https://github.com/apache/whimsy/pull/318#discussion_r3501527387
##########
lib/whimsy/sitewebsite.rb:
##########
@@ -206,6 +210,17 @@ def display_overview(sites, analysis, checks, tlp = true)
cls = SiteStandards.label(analysis, links, c, n)
_td '', class: cls, data_sort_value: sort_order[cls]
end
+ downloads = links['downloads'] || {}
+ if downloads.empty?
Review Comment:
Not all projects are expected to have Downloads - e.g. Data Privacy, Diversity (and indeed Whimsy)
This needs to be allowed for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Downloads pass/fail column to site-scan overview [whimsy]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on code in PR #318:
URL: https://github.com/apache/whimsy/pull/318#discussion_r3501597558
##########
lib/whimsy/sitewebsite.rb:
##########
@@ -206,6 +210,17 @@ def display_overview(sites, analysis, checks, tlp = true)
cls = SiteStandards.label(analysis, links, c, n)
_td '', class: cls, data_sort_value: sort_order[cls]
end
+ downloads = links['downloads'] || {}
+ if downloads.empty?
Review Comment:
That may be the all the actual PMCs that don't make releases, but other websites are included in the analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Downloads pass/fail column to site-scan overview [whimsy]
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on code in PR #318:
URL: https://github.com/apache/whimsy/pull/318#discussion_r3501613869
##########
lib/whimsy/sitewebsite.rb:
##########
@@ -206,6 +210,17 @@ def display_overview(sites, analysis, checks, tlp = true)
cls = SiteStandards.label(analysis, links, c, n)
_td '', class: cls, data_sort_value: sort_order[cls]
end
+ downloads = links['downloads'] || {}
+ if downloads.empty?
Review Comment:
True about the analysis, but those other websites are not displayed in this table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Downloads pass/fail column to site-scan overview [whimsy]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on code in PR #318:
URL: https://github.com/apache/whimsy/pull/318#discussion_r3501630765
##########
lib/whimsy/sitewebsite.rb:
##########
@@ -206,6 +210,17 @@ def display_overview(sites, analysis, checks, tlp = true)
cls = SiteStandards.label(analysis, links, c, n)
_td '', class: cls, data_sort_value: sort_order[cls]
end
+ downloads = links['downloads'] || {}
+ if downloads.empty?
Review Comment:
https://whimsy.apache.org/site/ includes Brand Management, Data Privacy, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org