You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/01/21 07:30:48 UTC
[GitHub] [hadoop] tomscut opened a new pull request #3912: HDFS-13923. Add a configuration to turn on/off observer reads
tomscut opened a new pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912
JIRA: [HDFS-13923](https://issues.apache.org/jira/browse/HDFS-13923).
Remove the `TODO comment` that are not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1028509813
Hi @sunchao @ayushtkn , could you please merge this? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1021932343
Hi @sunchao , could you please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1024303819
> LGTM. If no comments for a couple of days. I think we can go ahead and merge this
Thanks @ayushtkn for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1022728568
> It makes sense to me, I honestly don't understand what was the intend of that TODO.
> Can you loop in the actual author/reviewer of that code as well to confirm.
Thanks @ayushtkn for your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn merged pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
ayushtkn merged pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1023788767
I wanted to implement this todo, but found the discussion in [HDFS-13923](https://issues.apache.org/jira/browse/HDFS-13923) quite sensible. We did not think need to add a configuration to turn on/off observer reads. So I suggest removing the todo comment.
@jojochuang @shvachko @xkrogen Could you please also take a look? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1028553130
Sorry I forgot to merge. :-(
Thanx @tomscut for the contribution & @sunchao for the review!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1028591406
Thanks @ayushtkn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #3912: HDFS-13923. Add a configuration to turn on/off observer reads
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1019778900
The title and the actual code are poles apart. From the title it looks like you are going to add some config. Where as the actual code is just removing a TODO.
Can you update the title. And add the description why this is no longer a TODO, for people coming in future to know, why this TODO was dropped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #3912: HDFS-13923. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1019787146
> Based on discussion in [HDFS-13923](https://issues.apache.org/jira/browse/HDFS-13923), we don't think need to Add a configuration to turn on/off observer reads.
>
> So I suggest removing the `TODO comment` that are not needed.
Hi @ayushtkn , I am sorry that I did not explain the reason in the PR description.
Based on discussion in [HDFS-13923](https://issues.apache.org/jira/browse/HDFS-13923), we don't think need to Add a configuration to turn on/off observer reads. So I suggest removing the `TODO comment` that are not needed.
I don't know if it is appropriate to change the title of the original ISSUE, this PR is just a suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1019795282
> > Based on discussion in [HDFS-13923](https://issues.apache.org/jira/browse/HDFS-13923), we don't think need to Add a configuration to turn on/off observer reads.
> > So I suggest removing the `TODO comment` that are not needed.
>
> Hi @ayushtkn , I am sorry that I did not explain the reason in the PR description.
>
> Based on discussion in [HDFS-13923](https://issues.apache.org/jira/browse/HDFS-13923), we don't think need to Add a configuration to turn on/off observer reads. So I suggest removing the `TODO comment` that are not needed.
>
> I don't know if it is appropriate to change the title of the original ISSUE, this PR is just a suggestion.
I created a new JIRA [HDFS-16435](https://issues.apache.org/jira/browse/HDFS-16435). @ayushtkn Please take a look. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #3912: HDFS-13923. Add a configuration to turn on/off observer reads
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1018319686
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 41s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 35s | | trunk passed |
| +1 :green_heart: | compile | 1m 5s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 0m 56s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 30s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 2s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 47s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 36s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 36s | | trunk passed |
| +1 :green_heart: | shadedclient | 24m 3s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 54s | | the patch passed |
| +1 :green_heart: | compile | 0m 58s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 0m 58s | | the patch passed |
| +1 :green_heart: | compile | 0m 51s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 0m 51s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 20s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 54s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 36s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 32s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 55s | | the patch passed |
| +1 :green_heart: | shadedclient | 23m 52s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 26s | | hadoop-hdfs-client in the patch passed. |
| +1 :green_heart: | asflicense | 0m 35s | | The patch does not generate ASF License warnings. |
| | | 99m 43s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3912/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/3912 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 2941f32c9bb1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 243d000e8c081c935cef69af8578520d3e305b98 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3912/1/testReport/ |
| Max. process+thread count | 550 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3912/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1023785767
> I think [HDFS-16435](https://issues.apache.org/jira/browse/HDFS-16435) added it. Haven't touched observer namenode for a while now so not sure if anybody still find a configuration useful.
Thanks @sunchao for your review and comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #3912: HDFS-16435. Remove no need TODO comment for ObserverReadProxyProvider
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1022369045
It makes sense to me, I honestly don't understand what was the intend of that TODO.
Can you loop in the actual author/reviewer of that code as well to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org