You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vrjdev (via GitHub)" <gi...@apache.org> on 2026/08/12 01:27:01 UTC
[PR] [SPARK-58721][K8S] Add tests for ClientArguments.fromCommandLineArgs [spark]
vrjdev opened a new pull request, #57944:
URL: https://github.com/apache/spark/pull/57944
### What changes were proposed in this pull request?
Adds unit tests for `ClientArguments.fromCommandLineArgs` in `KubernetesClientApplication.scala`, covering all supported command-line flags and its error paths.
### Why are the changes needed?
This is a small, pure function with zero direct test coverage. The sibling `Client` class in the same file is thoroughly tested via `ClientSuite.scala`, but `ClientArguments`' own parsing logic - including its error paths (missing `--main-class`, an unrecognized flag, a trailing flag with no value) - was untested.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
New unit tests in `ClientArgumentsSuite.scala`, run locally via `build/sbt -Pkubernetes 'kubernetes/testOnly *ClientArgumentsSuite'` - all 11 tests pass.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Sonnet 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58721][K8S] Add tests for ClientArguments.fromCommandLineArgs [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57944:
URL: https://github.com/apache/spark/pull/57944#issuecomment-5463254902
Sorry, @vrjdev! Please consider adding [TESTS] to the PR title, because these are test-only changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58721][K8S] Add tests for ClientArguments.fromCommandLineArgs [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57944:
URL: https://github.com/apache/spark/pull/57944#issuecomment-5262872591
Thank you @vrjdev!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58721][K8S] Add tests for ClientArguments.fromCommandLineArgs [spark]
Posted by "vrjdev (via GitHub)" <gi...@apache.org>.
vrjdev commented on PR #57944:
URL: https://github.com/apache/spark/pull/57944#issuecomment-5275292768
Hi @uros-b , thanks for reviewing the PR, what is the cadence for merging the PRs ? new to this and would appreciate any information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58721][K8S][TESTS] Add tests for ClientArguments.fromCommandLineArgs [spark]
Posted by "vrjdev (via GitHub)" <gi...@apache.org>.
vrjdev commented on PR #57944:
URL: https://github.com/apache/spark/pull/57944#issuecomment-5546378138
@LuciferYang can you please review this when you get time. These are small tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58721][K8S] Add tests for ClientArguments.fromCommandLineArgs [spark]
Posted by "vrjdev (via GitHub)" <gi...@apache.org>.
vrjdev commented on PR #57944:
URL: https://github.com/apache/spark/pull/57944#issuecomment-5374150449
Hi @uros-b , any update on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58721][K8S] Add tests for ClientArguments.fromCommandLineArgs [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57944:
URL: https://github.com/apache/spark/pull/57944#issuecomment-5463255676
Also, adding @LuciferYang here for K8s ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org