You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/11/25 15:59:25 UTC
[GitHub] couchdb-fauxton pull request: build: add json suffix to json files
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/581
build: add json suffix to json files
adding a .json suffix to our json files enables us to use the
faster native `require` from node instead of grunts wrapper
around the file api with a json parser.
decoupling the reading from grunt enables us to slice out small
parts of our build without a hard dependency to the grunt
monolith.
notes:
- throw instead of silently fail in case of a missing
settings.json. if the settings.json is missing fauxton can't
run, there is no reason to return a stub
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton settings-json-ending
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/581.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #581
----
commit 3a492d062ea4d9dfad0721854ef4835ae7e335bd
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-11-25T14:56:28Z
build: add json suffix to json files
adding a .json suffix to our json files enables us to use the
faster native `require` from node instead of grunts wrapper
around the file api with a json parser.
decoupling the reading from grunt enables us to slice out small
parts of our build without a hard dependency to the grunt
monolith.
notes:
- throw instead of silently fail in case of a missing
settings.json. if the settings.json is missing fauxton can't
run, there is no reason to return a stub
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: add json suffix to json files
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/581#issuecomment-159921337
merged as 8f84268cf9d8d16d13bc43068edc31483193b2a0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: add json suffix to json files
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: add json suffix to json files
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/581#issuecomment-159643017
+1 everything seems to work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---