[PATCH] Translate.java (Was: Re: [SUBMIT] Translate - a useful task for i18n)

[Magesh Umasankar <um...@rediffmail.com>]

On Sat, 03 Nov 2001 Peter Donald wrote :
> I should note that I changed all protected members to 
> private. Tell me if this causes any issues ;)


No, it doesn't cause any issues - the idea was to open 
up the methods that may be overridden if at all a task 
is going to be extending this one in the future...

I had noticed s small problem after I had submitted this
task and I had followed it up with a revision.  I see 
that the revision did not get applied.  Here is a patch 
that will get rid of this bug.

Please note that currently, the starttoken and endtoken 
values must be just a single character instead of a 
string of tokens (I am still working on making this task
recognize from a set of starttokens and endtokens.  I
have temporarily introduced validations to make sure
that these values are indeed 1 character in length.  

Please apply this patch.

Thanks,
Magesh

 

Re: [PATCH] Translate.java (Was: Re: [SUBMIT] Translate - a useful task for i18n)

[Peter Donald <do...@apache.org>]

On Sat, 3 Nov 2001 13:54, Magesh Umasankar wrote:
> On Sat, 03 Nov 2001 Peter Donald wrote :
>
> > I should note that I changed all protected members to 
> > private. Tell me if this causes any issues ;)
> 
> No, it doesn't cause any issues - the idea was to open 
> up the methods that may be overridden if at all a task 
> is going to be extending this one in the future...

if the need arises we can deal with it then. Making them private makes it 
easier evolve because no one will try to use them without making us aware of 
it.
 
> I had noticed s small problem after I had submitted this
> task and I had followed it up with a revision.  I see 
> that the revision did not get applied.  Here is a patch 
> that will get rid of this bug.

applied.

-- 
Cheers,

Pete

*-------------------------------------*
| Does the name `Pavlov' ring a bell? |
*-------------------------------------*

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>