[jira] [Commented] (AIRFLOW-3629) Not implemented methods in Base Hook

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743195#comment-16743195 ] 

ASF GitHub Bot commented on AIRFLOW-3629:
-----------------------------------------

potiuk commented on pull request #4538: [AIRFLOW-3629] remove abstract methods from base hook
URL: https://github.com/apache/airflow/pull/4538
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3629
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Those four abstract methods in Base Hook are removed:
   
   get_conn()
   get_records()
   get_pandas_df()
   run(sql)
   
   Those methods being abstract (raising NotImplementedError) in
   BaseHook are not needed.
   
   They generate warnings in smart IDEs
   (such as Pycharm/IntelliJ) but they bring no value. Not all hooks
   are supposed to implement them. Seems that only hooks that have a
   DB-hook-like behaviour implement most of the methods.
   
   Having abstract DB class with those methods and having relevant
   classes to inherit from them seems to make much more sense.
   
   ### Tests
   
   - [x] My PR  does not need testing for this extremely good reason:
   
   No new functionality. Existing tests should test it all :).
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
   No new functionality
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Not implemented methods in Base Hook
> ------------------------------------
>
>                 Key: AIRFLOW-3629
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3629
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Jarek Potiuk
>            Assignee: Jarek Potiuk
>            Priority: Major
>
> There are four not implemented methods in Base Hook:
>  * get_conn()
>  * get_records()
>  * get_pandas_df()
>  * run(sql)
> They are clearly DB API related but they are in Base Hook and then IDE's/static analysis produces annoying "Abstract Class" warning about all the hooks which do not implement those methods. - it seem that we need another separate abstract class that the DB API-related hooks will derive from.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)