[jira] [Comment Edited] (KNOX-2221) Upgrade shiro to 1.5.1

["Kevin Risden (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043833#comment-17043833 ] 

Kevin Risden edited comment on KNOX-2221 at 2/24/20 8:24 PM:
-------------------------------------------------------------

Hmmmm so looks like another test is failing due to SHIRO-684. 

It looks like there is no way to escape backslashes anymore? They are stripped if you want to actually have a literal backslash.

This comes up in GatewayMultiFuncTest.testLdapSearchConfigEnhancementsKnox694:

{code:java}
            <param>
                <name>main.ldapRealm.principalRegex</name>
                <value>(.*?)\\(.*)</value>
            </param>
{code}

https://github.com/apache/knox/blob/master/gateway-test/src/test/resources/org/apache/knox/gateway/GatewayMultiFuncTest/topologies/test-knox694-principal-regex-user-dn-template.xml#L45

The principalRegex goes from

{code:java}
(.*?)\\(.*)
{code}

to 

{code:java}
(.*?)(.*)
{code}

which is a completely different value and therefore doesn't match.


was (Author: risdenk):
Hmmmm so looks like another test is failing due to SHIRO-684. 

It looks like there is no way to escape backslashes anymore? They are stripped if you want to actually have a literal backslash.

This comes up in GatewayMultiFuncTest.testLdapSearchConfigEnhancementsKnox694:

{code:java}
            <param>
                <name>main.ldapRealm.principalRegex</name>
                <value>(.*?)\\(.*)</value>
            </param>
{code}

https://github.com/apache/knox/blob/master/gateway-test/src/test/resources/org/apache/knox/gateway/GatewayMultiFuncTest/topologies/test-knox694-principal-regex-user-dn-template.xml#L45

The principalRegex goes from "(.*?)\\(.*)" to "(.*?)(.*)" which is a completely different value and therefore doesn't match.

> Upgrade shiro to 1.5.1
> ----------------------
>
>                 Key: KNOX-2221
>                 URL: https://issues.apache.org/jira/browse/KNOX-2221
>             Project: Apache Knox
>          Issue Type: Sub-task
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Major
>             Fix For: 1.4.0
>
>         Attachments: log.txt.gz
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> *Note:* Can't upgrade to shiro 1.5.0 due to a bug in handling `/` only from SHIRO-682. Will need to wait for a new version of Shiro to upgrade.
> Upgrade shiro 1.4.2 to 1.5.1
> Shiro 1.5.0 release notes: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310950&version=12344991



--
This message was sent by Atlassian Jira
(v8.3.4#803005)