[GitHub] [airflow] feng-tao commented on a change in pull request #5220: [AIRFLOW-4450] has_dag_access does not use correct request arguments from POST endpoints

[GitBox <gi...@apache.org>]

feng-tao commented on a change in pull request #5220: [AIRFLOW-4450] has_dag_access does not use correct request arguments from POST endpoints
URL: https://github.com/apache/airflow/pull/5220#discussion_r279989391
 
 

 ##########
 File path: airflow/www/decorators.py
 ##########
 @@ -101,8 +101,10 @@ def has_dag_access(**dag_kwargs):
     def decorator(f):
         @functools.wraps(f)
         def wrapper(self, *args, **kwargs):
+            request_arguments = request.args.to_dict()
+            request_arguments.update(request.form.to_dict())
 
 Review comment:
   The decorator has been used in many people. Does it work for GET/PUT endpoint as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services