You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2008/09/20 06:00:19 UTC
Re: svn commit: r33203 - in branches/file-externals/subversion: include libsvn_wc tests/cmdline
On Fri, Sep 19, 2008 at 9:32 PM, <bl...@tigris.org> wrote:
>...
> +++ branches/file-externals/subversion/tests/cmdline/externals_tests.py Fri Sep 19 21:32:17 2008 (r33203)
>...
> @@ -1000,7 +1050,8 @@ test_list = [ None,
> external_with_peg_and_op_revision,
> new_style_externals,
> disallow_propset_invalid_formatted_externals,
> - old_style_externals_ignore_peg_reg
> + old_style_externals_ignore_peg_reg,
> + cannot_rm_file_externals
> ]
You should put a trailing comma on those elements. Python is fine with
that. And it means that future changes are just adding a line, rather
than modify one line, and add another.
Cheers,
-g
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33203 - in branches/file-externals/subversion: include
libsvn_wc tests/cmdline
Posted by Blair Zajac <bl...@orcaware.com>.
Greg Stein wrote:
> On Fri, Sep 19, 2008 at 9:32 PM, <bl...@tigris.org> wrote:
>> ...
>> +++ branches/file-externals/subversion/tests/cmdline/externals_tests.py Fri Sep 19 21:32:17 2008 (r33203)
>> ...
>> @@ -1000,7 +1050,8 @@ test_list = [ None,
>> external_with_peg_and_op_revision,
>> new_style_externals,
>> disallow_propset_invalid_formatted_externals,
>> - old_style_externals_ignore_peg_reg
>> + old_style_externals_ignore_peg_reg,
>> + cannot_rm_file_externals
>> ]
>
> You should put a trailing comma on those elements. Python is fine with
> that. And it means that future changes are just adding a line, rather
> than modify one line, and add another.
Thanks, fixed in r33210.
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org